Hello Andrew,
From: Andreas Karlsson <andr...@proxel.se>
> # Nitpicking
>
> The certificate expires in 2030 while all other certificates used in
> tests expires in 2046. Should we be consistent?
>
> There is text in server.crt and server.key, while other certificates and
> keys used in the tests do not have this. Again, should we be consistent?
>
> Empty first line in
> src/test/modules/ssl_passphrase_callback/t/001_testfunc.pl which should
> probably just be removed or replaced with a shebang.
>
> There is an extra space between the parentheses in the line below. Does
> that follow our code style for Perl?
>
> +unless ( ($ENV{with_openssl} || 'no') eq 'yes')
>
> Missing space after comma in:
>
> +ok(-e "$ddir/postmaster.pid","postgres started");
>
> Missing space after comma in:
>
> +ok(! -e "$ddir/postmaster.pid","postgres not started with bad passphrase");
>
> Andreas
>
Trailing space:
220 + X509v3 Subject Key Identifier:
222 + X509v3 Authority Key Identifier:
Missing "d"(password?):
121 +/* init hook for SSL, the default sets the passwor callback if appropriate
*/
Regards,
--
Takanori Asaba
