On Mon, Mar 16, 2020 at 10:20 PM Andrey M. Borodin <x4...@yandex-team.ru> wrote: > It seems to me that it's exactly the same check that I was trying to verify > in amcheck patch [0]. > But there it was verified inside amcheck, but here it is verified by index > scan.
Maybe we can accept your patch after fixing this bug. My objection to the patch was that it couples locks in a way that's not compatible with btree_xlog_unlink_page(). But the problem now seems to have been btree_xlog_unlink_page() itself. It's possible that there are problems elsewhere, but my recollection is that btree_xlog_unlink_page() was the problem. -- Peter Geoghegan