Thanks for your comments! On Mon, Mar 16, 2020 at 11:49 AM Fujii Masao <masao.fu...@oss.nttdata.com> wrote:
> - <term><literal>buffering</literal> > + <term><literal>buffering</literal> (<type>string</type>) > > Isn't it better to use "enum" rather than "string"? > In the docs about enum GUC parameters, "enum" is used there. > Agreed. I've fixed it to "enum". But I'm now wondering about the type of check_option[3], [4]. Because I decide the type to "string" referring to check_option, which is the other element of enumRelOpts in reloptions.c. Should I also change it to "enum"? [3]https://www.postgresql.org/docs/devel/sql-alterview.html#id-1.9.3.45.6 [4]https://www.postgresql.org/docs/devel/sql-createview.html#id-1.9.3.97.6 Regards, -- Torikoshi Atsushi
add_type_in_createindex_storage-params_v2.patch
Description: Binary data
