On Tue, Mar 03, 2020 at 05:06:42PM +0900, Michael Paquier wrote: > Attached is a draft patch to take care of that problem for HEAD. It > still needs a lot of polishing (variable names are not actually old > or new anymore, etc.) but that's enough to show the idea. If a version > reaches PG12, we would need to keep around the past routines to avoid > an ABI breakage, even if I doubt there are callers of it, but who > knows..
Or actually, a more simple solution is to abuse of the two existing routines so as the dependency switch is done the other way around, from the new index to the old one. That would visibly work because there is no CCI between each scan, and that's faster because the scan of pg_depend is done only on the entries in need of an update. I'll look at that again tomorrow, it is late here and I may be missing something obvious. -- Michael
diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c index 1681f61727..736bc9f66c 100644 --- a/src/backend/catalog/index.c +++ b/src/backend/catalog/index.c @@ -1675,14 +1675,13 @@ index_concurrently_swap(Oid newIndexId, Oid oldIndexId, const char *oldName) } /* - * Move all dependencies of and on the old index to the new one. First - * remove any dependencies that the new index may have to provide an - * initial clean state for the dependency switch, and then move all the - * dependencies from the old index to the new one. + * Swap all dependencies of and on the old index to the new one, and + * vice-versa. */ - deleteDependencyRecordsFor(RelationRelationId, newIndexId, false); changeDependenciesOf(RelationRelationId, oldIndexId, newIndexId); changeDependenciesOn(RelationRelationId, oldIndexId, newIndexId); + changeDependenciesOf(RelationRelationId, newIndexId, oldIndexId); + changeDependenciesOn(RelationRelationId, newIndexId, oldIndexId); /* * Copy over statistics from old to new index
signature.asc
Description: PGP signature
