Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes: > I came across the HAVE_WORKING_LINK define in pg_config_manual.h. > AFAICT, hard links are supported on Windows and Cygwin in the OS > versions that we support, and pg_upgrade already contains the required > shim. It seems to me we could normalize and simplify that, as in the > attached patches. (Perhaps rename durable_link_or_rename() then.) I > successfully tested on MSVC, MinGW, and Cygwin.
I don't have any way to test on Windows, but this patchset passes eyeball review. +1 for getting rid of the special cases. Also +1 for s/durable_link_or_rename/durable_link/. regards, tom lane