Hello.

> The patch about making color by default [1] introduces the function 
> terminal_supports_color(), that I think is relevant for this issue. Please 
> find attached a new version based on that idea.

I am not sure it is good idea to mix both patches because it adds some
confusion and makes it harder to merge each.
Maybe is it better to update current patch the way to reuse some
function later in [1]?

Also, regarding comment
> It is disabled by default, so it must be enabled to use color outpout.

It is not true for new terminal, for example. Maybe it is better to
rephrase it to something like: "Check if TV100 support if enabled and
attempt to enable if not".

[1] 
https://www.postgresql.org/message-id/flat/bbdcce43-bd2e-5599-641b-9b44b9e0a...@2ndquadrant.com


Reply via email to