On Fri, Jan 31, 2020 at 4:35 PM Craig Ringer <cr...@2ndquadrant.com> wrote: > > On Fri, 31 Jan 2020 at 13:27, Michael Paquier <mich...@paquier.xyz> wrote: > > > > On Fri, Jan 31, 2020 at 12:47:29PM +1030, Andrew Dunstan wrote: > > > When I was working on the test_json stuff yesterday, I noticed that > > > there are some unexpected (by me at least) things installed when we do > > > an MSVC build: > > > > > > $ ls -l bin| egrep 'regress|isolation' > > > -rwxr-xr-x 1 pgrunner None 72192 Jan 30 07:51 isolationtester.exe > > > -rwxr-xr-x 1 pgrunner None 112640 Jan 30 07:51 pg_isolation_regress.exe > > > -rwxr-xr-x 1 pgrunner None 112128 Jan 30 07:51 pg_regress.exe > > > -rwxr-xr-x 1 pgrunner None 112640 Jan 30 07:51 pg_regress_ecpg.exe > > These tools should be installed. They are useful, important in fact, > for testing extensions. > > In *nix builds we install them to > $PREFIX/lib/postgresql/pgxs/src/test/regress/pg_regress etc. > > On Windows we don't have PGXS. It probably doesn't make sense to > install them to the pgxs dir. So putting them in bin is pretty > reasonable.
Oh, Ha! Forget I spoke. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services