On Thu, Feb 06, 2020 at 04:25:47PM +0900, Amit Langote wrote: > About the implementation, how about defining a static inline function, > say is_user_object(), next to FirstNormalObjectId's definition and > make pg_is_user_object() call it? There are a few placed in the > backend code that perform the same computation as pg_is_user_object(), > which could be changed to use is_user_object() instead.
FWIW, if we bother adding SQL functions for that, my first impression was to have three functions, each one of them returning: - FirstNormalObjectId - FirstGenbkiObjectId - FirstNormalObjectId Perhaps you should add a minimal set of regression tests in the patch. -- Michael
signature.asc
Description: PGP signature
