Julien Rouhaud <rjuju...@gmail.com> writes:
> On Sun, Dec 22, 2019 at 10:51 PM Tom Lane <t...@sss.pgh.pa.us> wrote:
>> While poking at this, I also started to wonder why CheckAttributeType
>> wasn't recursing into ranges, since those are our other kind of
>> container type. And the answer is that it must, because we allow
>> creation of ranges over composite types:
> While working on regression tests for index collation versioning [1],
> I noticed that the 2nd patch apparently broke the ability to create a
> table using a range over collatable datatype attribute, which we
> apparently don't test anywhere.
Ugh.
> AFAICT, this is only a thinko in CheckAttributeType(), where the range
> collation should be provided rather than the original tuple desc one,
> as per attached. I also added a create/drop table in an existing
> regression test that was already creating range over collatable type.
Looks good, although I think maybe we'd better test the case a little
harder than this. Will tweak that and push -- thanks!
regards, tom lane
