On Wed, Jan 29, 2020 at 2:00 PM Luis Carril <luis.car...@swarm64.com> wrote: > > Thanks for working on the comments. I noticed one behavior is > different when --table option is specified. When --table is specified > the following are not getting dumped: > CREATE SERVER foreign_server > > I felt the above also should be included as part of the dump when > include-foreign-data option is specified. > > Yes, it also happens on master. A dump of a foreign table using --table, > which only dumps the table definition, does not include the extension nor the > server. > I guess that the idea behind --table is that the table prerequisites should > already exist on the database. > > A similar behavior can be reproduced for a non foreign table. If a table is > created in a specific schema, dumping only the table with --table does not > dump the schema definition. > > So I think we do not need to dump the server with the table. >
Thanks for the clarification, the behavior sounds reasonable to me unless others have a different opinion on this. Regards, Vignesh EnterpriseDB: http://www.enterprisedb.com
