On Tue, 28 Jan 2020 at 20:36, Robert Haas <robertmh...@gmail.com> wrote: > > On Mon, Jan 27, 2020 at 2:02 PM Mahendra Singh Thalor > <mahi6...@gmail.com> wrote: > > I can see one warning on HEAD. > > > > jsonapi.c: In function ‘json_errdetail’: > > jsonapi.c:1068:1: warning: control reaches end of non-void function > > [-Wreturn-type] > > } > > ^ > > > > Attaching a patch to fix warning. > > Hmm, I don't get a warning there. This function is a switch over an > enum type with a case for every value of the enum, and every branch > either does a "return" or an "elog," so any code after the switch > should be unreachable. It's possible your compiler is too dumb to know > that, but I thought there were other places in the code base where we > assumed that if we handled every defined value of enum, that was good > enough. > > But maybe not. I found similar coding in CreateDestReceiver(), and > that ends with: > > /* should never get here */ > pg_unreachable(); > > So perhaps we need the same thing here. Does adding that fix it for you? >
Hi Robert, Tom Lane already fixed this and committed yesterday(4589c6a2a30faba53d0655a8e). -- Thanks and Regards Mahendra Singh Thalor EnterpriseDB: http://www.enterprisedb.com
