On Tue, Jan 28, 2020 at 8:56 AM Masahiko Sawada <masahiko.saw...@2ndquadrant.com> wrote: > > On Sat, 25 Jan 2020 at 15:41, Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > > I have made few modifications in the patch. > > > > 1. I think we should try to block the usage of 'full' and 'parallel' > > option in the utility rather than allowing the server to return an > > error. > > 2. It is better to handle 'P' option in getopt_long in the order of > > its declaration in long_options array. > > 3. Added an Assert for server version while handling of parallel option. > > 4. Added a few sentences in the documentation. > > > > What do you guys think of the attached? > > Your changes look good me. >
Thanks for the review. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
