Thomas Munro <thomas.mu...@gmail.com> writes: > [ 0001-Add-kqueue-2-support-for-WaitEventSet-v13.patch ]
I haven't read this patch in any detail, but a couple quick notes: * It needs to be rebased over the removal of pg_config.h.win32 --- it should be touching Solution.pm instead, I believe. * I'm disturbed by the addition of a hunk to the supposedly system-API-independent WaitEventSetWait() function. Is that a generic bug fix? If not, can we either get rid of it, or at least wrap it in "#ifdef WAIT_USE_KQUEUE" so that this patch isn't inflicting a performance penalty on everyone else? regards, tom lane