Hi po 30. 12. 2019 v 21:05 odesÃlatel Pavel Stehule <pavel.steh...@gmail.com> napsal:
> Hi > > po 30. 12. 2019 v 17:27 odesÃlatel Philippe BEAUDOIN <ph...@apra.asso.fr> > napsal: > >> The following review has been posted through the commitfest application: >> make installcheck-world: tested, passed >> Implements feature: tested, passed >> Spec compliant: not tested >> Documentation: tested, failed >> >> Hi Pavel, >> >> I have tested the latest version of your patch. >> Both issues I reported are now fixed. And you largely applied my >> proposals. That's great ! >> >> I have also spent some time to review more closely the documentation. I >> will send you a direct mail with an attached file for some minor comments >> on this topic. >> >> Except these documentation remarks to come, I haven't any other issue or >> suggestion to report. >> Note that I have not closely looked at the C code itself. But may be some >> other reviewers have already done that job. >> If yes, my feeling is that the patch could soon be set as "Ready for >> commiter". >> >> Best regards. Philippe. >> >> The new status of this patch is: Waiting on Author >> > > Thank you very much for your comments, and notes. Updated patch attached. > rebase > Regards > > Pavel > >
schema-variables-20200117.patch.gz
Description: application/gzip
