On Fri, Jan 17, 2020 at 7:42 AM vignesh C <vignes...@gmail.com> wrote: > > On Thu, Jan 16, 2020 at 9:17 AM Dilip Kumar <dilipbal...@gmail.com> wrote: > > > > One minor comment. Otherwise, the patch looks fine to me. > > + /* > > + * We set final_lsn on a transaction when we decode its commit or abort > > + * record, but we never see those records for crashed transactions. To > > + * ensure cleanup of these transactions, set final_lsn to that of their > > + * last change; this causes ReorderBufferRestoreCleanup to do the right > > + * thing. Final_lsn would have been set with commit_lsn earlier when we > > + * decode it commit, no need to update in that case > > + */ > > + if (txn->final_lsn < change->lsn) > > + txn->final_lsn = change->lsn; > > > > /decode it commit,/decode its commit, > > > > Thanks Dilip for reviewing. > I have fixed the comments you have suggested. > Thanks for the updated patch. It looks fine to me.
-- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
