> "Peter Eisentraut" <peter.eisentr...@2ndquadrant.com> skrev 14. januar 2020 > kl. 21:13: > > On 2019-12-11 12:40, Leif Gunnar Erlandsen wrote: >> Adding patch written for 13dev from git >> "Michael Paquier" <mich...@paquier.xyz> skrev 1. desember 2019 kl. 03:08: >> On Fri, Nov 22, 2019 at 11:26:59AM +0000, Leif Gunnar Erlandsen wrote: > >> No it does not. It works well to demonstrate its purpose though. >> And it might be to stop with FATAL would be more correct. > > This is still under active discussion. Please note that the latest > patch does not apply, so a rebase would be nice to have. I have moved > the patch to next CF, waiting on author. > > I reworked your patch a bit. I changed the outcome to be an error, as was > discussed. I also added > tests and documentation. Please take a look.
Thank you, it was not unexpexted for the patch to be a little bit smaller. Although it would have been nice to log where recover ended before reporting fatal error. And since you use RECOVERY_TARGET_UNSET, RECOVERY_TARGET_IMMEDIATE also gets included, is this correct? > -- Peter Eisentraut http://www.2ndQuadrant.com > PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
