On Fri, Jan 10, 2020 at 10:31 AM Michael Paquier <mich...@paquier.xyz> wrote: > > On Fri, Jan 10, 2020 at 07:30:34AM +0530, Dilip Kumar wrote: > > On Thu, 9 Jan 2020 at 10:43 PM, Andres Freund <and...@anarazel.de> wrote: > >> There's not much point in having this assert, right? Given that it > >> covers all choices? Seems better to just drop it. > > > > Yeah right! > > Refreshing my mind on that... The two remaining assertions still make > sense for update and delete changes per the restrictions in place in > CheckCmdReplicaIdentity(),
Right and there is a gap with the regression > tests. So combining all that I get the attached patch (origin point > is 665d1fa). Thoughts? LGTM -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
