Re: pgsql: Add basic TAP tests for psql's tab-completion logic.

[Dagfinn Ilmari Mannsåker]

On 5 January 2020 16:38:36 GMT, Tom Lane <t...@sss.pgh.pa.us> wrote:
>ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
>> Here's one final style cleanup for the TAP test.
>
>LGTM, pushed.

Thanks!

>One minor note: you wanted to change the \DRD test to
>
>+check_completion("\\DRD\t", qr/\\drds /, "complete \\DRD<tab> to
>\\drds");
>
>but that doesn't work everywhere, unfortunately.  On my machine
>what comes out is
>
># Actual output was "\\DRD\b\b\bdrds "
># Did not match "(?-xism:\\drds )"

Sorry, that was something I left in for testing the diagnostic and forgot to 
remove before committing.

>                       regards, tom lane

- ilmari