On Fri, Jan 3, 2020 at 9:59 AM Robert Haas <robertmh...@gmail.com> wrote: > I take no position on whether Debian is correct in its assessment of > such things, but I reiterate my previous opposition to breaking it > just because we don't agree with it, or because Tom specifically > doesn't. It's too mainstream a platform to arbitrarily break. And it > will probably just have the effect of increasing the number of patches > they're carrying against our sources, which will not make things > better for anybody.
Even with commit 56a3921a, "make check-world" is broken on my Ubuntu 18.04 workstation. This is now adversely impacting my work, so I hope it can be resolved soon. Not sure if the specifics matter, but FWIW "make check-world" ended with the following failure just now: make[2]: Entering directory '/code/postgresql/patch/build/src/bin/psql' rm -rf '/code/postgresql/patch/build/src/bin/psql'/tmp_check /bin/mkdir -p '/code/postgresql/patch/build/src/bin/psql'/tmp_check cd /code/postgresql/patch/build/../source/src/bin/psql && TESTDIR='/code/postgresql/patch/build/src/bin/psql' PATH="/code/postgresql/patch/build/tmp_install/code/postgresql/patch/install/bin:$PATH" LD_LIBRARY_PATH="/code/postgresql/patch/build/tmp_install/code/postgresql/patch/install/lib" PGPORT='65432' PG_REGRESS='/code/postgresql/patch/build/src/bin/psql/../../../src/test/regress/pg_regress' REGRESS_SHLIB='/code/postgresql/patch/build/src/test/regress/regress.so' /usr/bin/prove -I /code/postgresql/patch/build/../source/src/test/perl/ -I /code/postgresql/patch/build/../source/src/bin/psql t/*.pl t/010_tab_completion.pl .. 8/? # Failed test 'offer multiple table choices' # at t/010_tab_completion.pl line 105. # Actual output was "\r\n\e[01;35mmytab\e[0m\e[K123\e[0m\e[K \e[01;35mmytab\e[0m\e[K246\e[0m\e[K \r\npostgres=# select * from mytab\r\n\e[01;35mmytab\e[0m\e[K123\e[0m\e[K \e[01;35mmytab\e[0m\e[K246\e[0m\e[K \r\npostgres=# select * from mytab" # # Looks like you failed 1 test of 12. t/010_tab_completion.pl .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/12 subtests Test Summary Report ------------------- t/010_tab_completion.pl (Wstat: 256 Tests: 12 Failed: 1) Failed test: 8 Non-zero exit status: 1 Files=1, Tests=12, 7 wallclock secs ( 0.02 usr 0.00 sys + 0.80 cusr 0.09 csys = 0.91 CPU) Result: FAIL Makefile:87: recipe for target 'check' failed make[2]: *** [check] Error 1 make[2]: Leaving directory '/code/postgresql/patch/build/src/bin/psql' Makefile:41: recipe for target 'check-psql-recurse' failed make[1]: *** [check-psql-recurse] Error 2 make[1]: Leaving directory '/code/postgresql/patch/build/src/bin' GNUmakefile:70: recipe for target 'check-world-src/bin-recurse' failed make: *** [check-world-src/bin-recurse] Error 2 -- Peter Geoghegan
