Le sam. 21 déc. 2019 à 18:46, Bruce Momjian <br...@momjian.us> a écrit :
> On Thu, Dec 5, 2019 at 11:45:09PM +0100, Daniel Gustafsson wrote: > > > On 5 Dec 2019, at 10:17, Julien Rouhaud <rjuju...@gmail.com> wrote: > > > > > While reading pg_upgrade code to restore the objects on the new > > > cluster, I noticed that 5b570d771b8 didn't adjust the database name in > > > the comments explaining the requirements for an extra "--clean" for > > > template1 and postgres databases. While it's true that both databases > > > will already exist, I found it confusing to mention both names when > > > only one is processed for each code path. > > > > Agreed, I think this reads better. > > FYI, this patch was applied: > > commit 690c880269 > Author: Michael Paquier <mich...@paquier.xyz> > Date: Fri Dec 6 11:55:04 2019 +0900 > > Improve some comments in pg_upgrade.c > > When restoring database schemas on a new cluster, database > "template1" > is processed first, followed by all other databases in > parallel, > including "postgres". Both "postgres" and "template1" have > some extra > handling to propagate each one's properties, but comments were > confusing > regarding which one is processed where. > > Author: Julien Rouhaud > Reviewed-by: Daniel Gustafsson > Discussion: > https://postgr.es/m/caobau_a2ivitg7fe10yo_gcw+zqchnfhra_ndiktf3ur65b...@mail.gmail.com Thanks Bruce, and thanks Michael for pushing!
