Ranier Vilela <ranier...@gmail.com> writes: > More about expressions always false. > 2. src/backend/utils/adt/formatting.c > result is declared long. Comparison with int limits is always false. > 3. src/backend/utils/adt/jsonfuncs.c > lindex is declared long. . Comparison with int limits is always false.
1) long is 64 bits on Unix-like platforms 2) checking a long against LONG_MIN/LONG_MAX is _definitely_ pointless 3) it's being cast to an int for the from_char_set_int() call below Please take your time to read the whole context of the code you're changing, and consider other platforms than just Windows. - ilmari -- "A disappointingly low fraction of the human race is, at any given time, on fire." - Stig Sandbeck Mathisen
