Good question. I am in favor of allowing a larger value if no one objects. I don't think adding the min/max is helpful.
--------------------------------------------------------------------------- On Tue, Nov 26, 2019 at 05:59:25PM +0300, v.maka...@postgrespro.ru wrote: > Hi Hackers, > > Some ORMs may generate queries larger than the maximum possible value of > track_activity_query_size (100 kB). > Is there any reasons to limit the maximum value of track_activity_query_size > to such small value? > Increasing the maximum value to 1 MB will help partially solve this problem. > Also in the file postgresql.conf.sample pointed maximum value > track_activity_query_size (before that it was not specified). > > -- > Vyacheslav Makarov > Postgres Professional: http://www.postgrespro.com > The Russian Postgres Company > diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c > index ba4edde71a..0e64dc1dbb 100644 > --- a/src/backend/utils/misc/guc.c > +++ b/src/backend/utils/misc/guc.c > @@ -3200,7 +3200,7 @@ static struct config_int ConfigureNamesInt[] = > GUC_UNIT_BYTE > }, > &pgstat_track_activity_query_size, > - 1024, 100, 102400, > + 1024, 100, 1048576, > NULL, NULL, NULL > }, > > diff --git a/src/backend/utils/misc/postgresql.conf.sample > b/src/backend/utils/misc/postgresql.conf.sample > index 46a06ffacd..55d3bfbfd0 100644 > --- a/src/backend/utils/misc/postgresql.conf.sample > +++ b/src/backend/utils/misc/postgresql.conf.sample > @@ -569,7 +569,7 @@ > #track_counts = on > #track_io_timing = off > #track_functions = none # none, pl, all > -#track_activity_query_size = 1024 # (change requires restart) > +#track_activity_query_size = 1024 # range 100B - 1MB (change requires > restart) > #stats_temp_directory = 'pg_stat_tmp' > > -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
