On Wed, Dec 18, 2019 at 12:34 PM Amit Khandekar <amitdkhan...@gmail.com> wrote: > > On Tue, 17 Dec 2019 at 17:40, Amit Khandekar <amitdkhan...@gmail.com> wrote: > > By the way, the backport patch is turning out to be simpler. It's > > because in pre-12 versions, the file offset is part of the Vfd > > structure, so all the offset handling is not required. > > Please have a look at the attached backport patch for PG 11. branch. > Once you are ok with the patch, I will port it on other branches. > Note that in the patch, wherever applicable I have renamed the fd > variable to vfd to signify that it is a vfd, and not the kernel fd. If > we don't do the renaming, the patch would be still smaller, but I > think the renaming makes sense. >
The other usage of PathNameOpenFile in md.c is already using 'fd' as a variable name (also, if you see example in fd.h, that also uses fd as variable name), so I don't see any problem with using fd especially if that leads to lesser changes. Apart from that, your patch LGTM. > The recovery TAP tests don't seem to be there on 9.4 and 9.5 branch, > so I think it's ok to not have any tests with the patches on these > branches that don't have the tap tests. > Yeah, that is fine. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
