On Sat, Dec 14, 2019 at 10:24 PM Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Dec 12, 2019 at 2:33 PM Andres Freund <and...@anarazel.de> wrote: > > I was basically just thinking that we could pass the context to use via > > CurrentMemoryContext, instead of explicitly passing it in. > > I thought about that, but as a general rule, replacing a function > parameter with a global variable is the wrong direction. One could > argue this particular case is a counterexample, and I won't fight > tooth and nail if you want to take that position, but I don't think I > believe it myself.
After confirming with Andres that he didn't have an objection to me pressing forward with these patches, I have committed them. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
