On Fri, Dec 13, 2019 at 03:14:08PM +0200, Heikki Linnakangas wrote: > On 13/12/2019 14:51, Peter Eisentraut wrote: >> Keeping pg_config.h.win32 up to date with pg_config.h.in is a gratuitous >> annoyance. > > Hear hear!
Youpi.
> I don't think this @simple_defines is really any better than listing all the
> options directly with "$define{HAVE_ATOMICS} = 1". And some simple defines
> are already listed like that, e.g. HAVE_DECL_STRNLEN above that list.
Agreed.
It would be nice to put a comment close to FLEXIBLE_ARRAY_MEMBER,
where you use "/* */" as a way to emulate an empty value which is
still defined. Or would it be cleaner to just use an empty string?
--
Michael
signature.asc
Description: PGP signature
