On Fri, Nov 29, 2019 at 08:44:25AM +0100, Fabien COELHO wrote: > I do not have a Windows host, so I can only do blind tests. I just moved the > declaration out of !WIN32 scope in attached v7, which might solve the > resolution error. All other issues pointed out above seem fixed in the v6 > you sent.
Committed the patch after splitting things into two commits and after testing things from Linux and from a Windows console: the actual refactoring and the pgbench changes. While polishing the code, I have found the upthread argument of Ibrar quite appealing because there are use cases where a callback can be interesting on Windows, like simply being able to log the cancel event to a different source. So I have removed the callback restriction and the assertion, making the callback of psql a no-op on Windows. A second thing is that two large comments originally in psql had better be moved to cancel.c because the logic with libpq cancel routines applies only there. -- Michael
signature.asc
Description: PGP signature
