Re: psql - improve test coverage from 41% to 88%

[Michael Paquier]

Hi Fabien,

On Tue, Sep 17, 2019 at 04:48:06PM +0530, vignesh C wrote:
> Few comments:
> + [ 'START TRANSACTION', [ qr{ISOLATION LEVEL}, qr{(?!BEGIN)} ] ],
> + [ 'TABLE', [ qr{ONLY} ] ], # hmmm...
> + [ 'TRUNCATE', [ qr{CONTINUE IDENTITY} ] ],
> + [ 'UNLISTEN', [ ] ],
> 
> We can remove # hmmm... if not required
> 
> + [ 'UPDATE', [ qr{RETURNING} ] ],
> + [ 'VACUUM', [ qr{FREEZE} ] ],
> + [ 'VALUES', [ qr{ORDER BY} ] ],
> + [ 'WITH', [ qr{RECURSIVE} ] ], # SELECT duplicate?
> +);
> 
> We can remove # SELECT duplicate? if not required
> 
> +
> +psql('--log-file=/dev/null', 0, "SELECT 5432 AS pg\n",
> + [ qr/\b5432\b/ ], $EMPTY, 'psql -L null');
> +
> +psql('', 0, "\\copy public.regress_psql_tap_1_t1(data) FROM PROGRAM
> 'echo moe'\n",
> + [ qr/COPY 1\b/ ], $EMPTY, 'psql copy echo');
> +psql('', 0, "\\copy public.regress_psql_tap_1_t1(data) TO PROGRAM 'cat'\n",
> + [ qr/COPY 1\b/ ], $EMPTY, 'psql copy cat'); # :-)
> +
> +END_UNIX_ZONE:
> 
> We can remove # :-) if not required

Please note that you have received comments on this patch a couple of
weeks ago.  The patch was still marked as "needs review", which was
incorrect, and it does not apply.  Perhaps you did not notice it, so I
am moving it to next CF, waiting on author for a rebase and for
replies on those comments.
--
Michael

signature.asc
Description: PGP signature