Hi, >I see no problem with fixing this kind of inconsistency for >readability, so applied the change. Thank you.
>Anyway, when sending a patch there are a couple of things which can >make the life of people looking at what you send easier: >https://wiki.postgresql.org/wiki/Submitting_a_Patch<https://wiki.postgresql.org/wiki/Submitting_a_Patch> Yes, I will read. >One problem that I noted with the patch sent on this thread is that it >does not directly apply on the git repository. Folks on -hackers are >mainly used to diffs generated by git. So first I would recommend >that you set up a git repository of the tree, say with that: >git clone https://git.postgresql.org/git/postgresql.git I will make use. >Generating a patch can be done with git in a couple of ways from the >cloned repository, say: >1) git diff >2) git format-patch >Both can be applied with a simple "patch -p1" command or even the more >advanced "git am", still the latter is kind of picky. Thanks for the hints. >The code of Postgres is complex, so usually there are reasons why >things are done the way they are, and it is important to not be afraid >to ask questions. Also, making the subject of the emails you send >explicative enough is important. Please note pgsql-hackers has a lot >of traffic, and this helps some people in filtering out threads they >are not interested in. Well, my experience with pgsql-hackers, haven't been good. Ask questions, about the code, have not had good acceptance.. Best regards. Ranier Vilela
