On Fri, Nov 22, 2019 at 11:21:53AM +0100, Peter Eisentraut wrote: > After thinking about this a bit more, doing the temporary slot stuff on the > walsender side might lead to too many complications in practice. > > Here is another patch set that implements the temporary slot use on the > walreceiver side, essentially mirroring what pg_basebackup already does.
I have not looked at the patch, but controlling the generation of the slot from the client feels much more natural to me. This reuses the existing interface, which is consistent, and we avoid a new class of bugs if there is any need to deal with the cleanup of the slot on the WAL sender side it itself created. -- Michael
signature.asc
Description: PGP signature
