On Wed, Nov 20, 2019 at 4:54 PM Amit Khandekar <amitdkhan...@gmail.com> wrote: > - BufFileLoadBuffer() seems to deliberately ignore FileRead()'s return > value if it is -1 > if (file->nbytes < 0) file->nbytes = 0;
Ok, that's a different problem we need to fix then. But it does explain how we didn't know. And sure enough there is "unrecognized win32 error code: 38" LOG-spam on the build farm, at places where tuplestores are expected: https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=whelk&dt=2019-11-20%2002%3A41%3A41&stg=check