On Mon, Nov 18, 2019 at 10:59 AM Pavel Stehule <pavel.steh...@gmail.com> wrote: > po 18. 11. 2019 v 6:24 odesÃlatel Amit Kapila <amit.kapil...@gmail.com> > napsal: >> >> On Mon, Nov 18, 2019 at 10:33 AM Pavel Stehule <pavel.steh...@gmail.com> >> wrote: >> > >> > po 18. 11. 2019 v 4:43 odesÃlatel vignesh C <vignes...@gmail.com> napsal: >> >> >> >> >> >> I had seen that isolation test(src/test/isolation) has a framework to >> >> support this. You can have a look to see if it can be handled using >> >> that. >> > >> > >> > I'll look there >> > >> >> If we want to have a test for this, then you might want to look at >> test src/test/recovery/t/013_crash_restart. In that test, we keep a >> connection open and then validate whether it is terminated. Having >> said that, I think it might be better to add this as a separate test >> patch apart from main patch because it is a bit of a timing-dependent >> test and might fail on some slow machines. We can always revert this >> if it turns out to be an unstable test. > > > +1 >
So, are you planning to give it a try? I think even if we want to commit this separately, it is better to have a test for this before we commit. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
