On Wed, Nov 6, 2019 at 2:00 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > > Amit Langote <amitlangot...@gmail.com> writes: > > On Mon, Oct 14, 2019 at 5:02 AM Justin Pryzby <pry...@telsasoft.com> wrote: > >> I can't say much about the patch; there's a little typo: > >> "The nullability of inner relation keys prevents them to" > >> ..should say "prevent them from". > > > Thanks, will fix. > > Just to leave a breadcrumb in this thread --- the planner failure > induced by d25ea01275 has been fixed in 529ebb20a. The difficulty > with multiway full joins that Amit started this thread with remains > open, but I imagine the posted patches will need rebasing over > 529ebb20a.
Here are the rebased patches. I've divided the patch containing only cosmetic improvements into two patches, of which the latter only moves around code. Patch 0003 implements the actual fix to the problem with multiway joins. Thanks, Amit
0001-Some-cosmetic-improvements-to-partitionwise-join-cod.patch
Description: Binary data
0002-Move-some-code-from-joinrel.c-to-relnode.c.patch
Description: Binary data
0003-Fix-partitionwise-join-to-handle-FULL-JOINs-correctl.patch
Description: Binary data
