On 2019-Oct-23, Michael Paquier wrote: > On Wed, Oct 23, 2019 at 11:16:25AM +0900, Amit Langote wrote: > > IMO, parts of the patch that only refactors the existing code should > > be first in the list as it is easier to review, especially if it adds > > no new concepts. In this case, your patch to break StdRdOptions into > > more manageable chunks would be easier to understand if it built upon > > a simplified framework of parsing reloptions text arrays. > > Thanks for doing a split. This helps in proving the point that this > portion has independent value.
Not a split, yes? AFAICS this code is nowhere in Nikolay's proposed patchset -- it seems completely new development by Amit. Am I wrong? I also think that this has value -- let's go for it. I think I'll be back on Wednesday to review it, if you would prefer to wait. Thanks -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
