Hello. At Mon, 21 Oct 2019 08:29:39 -0400, Andrew Dunstan <andrew.duns...@2ndquadrant.com> wrote in > > On 10/20/19 7:36 PM, Tom Lane wrote: > > Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: > >> On 10/20/19 1:23 PM, Tom Lane wrote: > >>> The right way to fix it, likely, is to add CFLAGS_SL while performing this > >>> particular autoconf test, as that would replicate the switches used for > >>> plperl (and it turns out that adding -fPIC does solve this problem). > >>> But the configure script doesn't currently know about CFLAGS_SL, so we'd > >>> have to do some refactoring to approach it that way. Moving that logic > >>> from the platform-specific Makefiles into configure doesn't seem > >>> unreasonable, but it would make the patch bigger. > >> Sounds like a plan. I agree it's annoying to have to do something large > >> for something so trivial. > > Turns out it's not really that bad. We just have to transfer the > > responsibility for setting CFLAGS_SL from the platform Makefiles > > to the platform template files. (As a bonus, it'd be possible to > > allow users to override CFLAGS_SL during configure, as they can > > do for CFLAGS. But I didn't mess with that here.) > > > > I checked that this fixes the Fedora build problem, but I've not > > really tested it on any other platform. Still, there's not that > > much to go wrong, one would think. > > > > LGTM
However it's done, but it looks good to me and actually the problem is gone. Thaks! regards. -- Kyotaro Horiguchi NTT Open Source Software Center
