> On 8 Oct 2019, at 11:33, Nikolay Shaplov <dh...@nataraj.su> wrote: > > Whoa-whoa! > > I am not inventing something new here. Same code is already used in brin > (brin.c:820), gin (ginutils.c:602) and gist (gistutils.c:909) indexes. I've > just copied the idea, to do all index code uniform. > > This does not mean that these code can't be improved, but as far as I can > guess it is better to do it in small steps, first make option code uniform, > and > then improve all of it this way or another...
I didn’t spot it was an existing pattern. And I agree — making the code uniform will make it easier to evolve in future. Gets my vote. denty.
