On Fri, Sep 27, 2019 at 02:52:54PM -0400, David Steele wrote: > Restoring these files could cause surprising behaviors so it seems best > to let the restore process create them when needed. > > Patch is attached.
When taking a base backup from a standby, we have always copied recovery.conf if present, which would have triggered recovery (and a standby if standby_mode was enabled). Hence always including RECOVERY_SIGNAL_FILE would be consistent with the past behavior. Including STANDBY_SIGNAL_FILE would be consistent with checking if standby_mode was set or not in recovery.conf. We have replaced standby_mode by the standby signal file, so including it if present is consistent with the past as well, no? -- Michael
signature.asc
Description: PGP signature
