On Fri, Sep 27, 2019 at 11:40 AM Andres Freund <and...@anarazel.de> wrote: > Note that one of the additional reasons for the 1GB limit is that it > protects against int overflows. I'm somewhat unconvinced that that's a > sensible approach, but ...
It's not crazy. People using 'int' rather casually just as they use 'palloc' rather casually, without necessarily thinking about what could go wrong at the edges. I don't have any beef with that as a general strategy; I just think we should be trying to do better in the cases where it negatively affects the user experience. > It's worthwhile to note that additional passes over data are often quite > expensive, memory latency hasn't shrunk that much in last decade or > so. I have frequently seen all the memcpys from one StringInfo/char* > into another StringInfo show up in profiles. OK. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
