"Tsunakawa, Takayuki" <tsunakawa.ta...@jp.fujitsu.com> writes:
> In the following code in execTuples.c, shouldn' srcdesc point to the source
> slot's tuple descriptor? The attached fix passes make check. What kind of
> failure could this cause?
Yeah, sure looks like a typo to me too.
I temporarily changed the Assert to be "==" rather than "<=", and
it still passed check-world, so evidently we are not testing any
cases where the descriptors are of different lengths. This explains
the lack of symptoms. It's still a bug though, so pushed.
> BTW, I thought that in PostgreSQL coding convention, local variables should
> be defined at the top of blocks, but this function writes "for (int natts;".
Yeah, we've agreed to join the 21st century to the extent of allowing
local for-loop variables.
Thanks for the report!
regards, tom lane
