Hi Fabien, On Thu, Sep 19, 2019 at 1:55 PM Fabien COELHO <coe...@cri.ensmp.fr> wrote: > Hello Amit, > > >> Yes, on -i it will fail because the syntax will not be recognized. > > > > Maybe we should be checking the server version, which would allow to > > produce more useful error messages when these options are used against > > older servers, like > > > > if (sversion < 10000) > > fprintf(stderr, "cannot use --partitions/--partitions-method > > against servers older than 10"); > > > > We would also have to check that partition-method=hash is not used against > > v10. > > > > Maybe overkill? > > Yes, I think so: the error detection and messages would be more or less > replicated from the server and would vary from version to version. > > I do not think that it is worth going this path because the use case is > virtually void as people in 99.9% of cases would use a pgbench matching > the server version. For those who do not, the error message should be > clear enough to let them guess what the issue is. Also, it would be > untestable.
Okay, I can understand the desire to not add code for rarely occurring situations where the server's error is a good enough clue. > One thing we could eventually do is just to check pgbench version against > the server version like psql does and output a generic warning if they > differ, but franckly I do not think it is worth the effort: ISTM that > nobody ever complained about such issues. Agree. Thanks, Amit
