On Thu, Sep 5, 2019 at 11:10 AM Michael Paquier <mich...@paquier.xyz> wrote: > > On Thu, Sep 05, 2019 at 10:53:19AM +0900, Fujii Masao wrote: > > It's ok to use PG_RETURN_BOOL(false) instead of breaking out of the loop > > in that case. Which would make the code simpler. > > Okay. I would have done so FWIW. > > > But I don't think it's worth warning about postmaster death here > > because a backend will emit FATAL message like "terminating connection > > due to unexpected postmaster exit" in secure_read() after > > pg_promote() returns false. > > Good point, that could be equally confusing.
So, barring any objection, I will commit the attached patch. Regards, -- Fujii Masao
pg_promote_and_postmaster_death_v2.patch
Description: Binary data
