Hello Peter,

    On Sun, Aug 25, 2019 at 05:10:47PM +0200, Julien Rouhaud wrote:
   > I did some searching, and oid2name.c is also missing this.

    And pgbench, no?
 
Yes, the patch is slightly different.

Thanks, pushed all that together.

Great!

Could we maintain coverage by adding a TAP test? See 1 liner attached.

--
Fabien.
diff --git a/src/bin/pgbench/t/002_pgbench_no_server.pl b/src/bin/pgbench/t/002_pgbench_no_server.pl
index f7fa18418b..912312b7ca 100644
--- a/src/bin/pgbench/t/002_pgbench_no_server.pl
+++ b/src/bin/pgbench/t/002_pgbench_no_server.pl
@@ -157,6 +157,7 @@ my @options = (
 			qr{error while setting random seed from --random-seed option}
 		]
 	],
+	[	'too many args', 'dbname foo', [ qr{too many .*first is "foo"} ] ],
 
 	# logging sub-options
 	[

Reply via email to