On 2019-Jul-23, David Rowley wrote: > I don't know my way around the tap tests that well, but I started to > look at this and ended up a bit stuck on where the test should be > located. I see src/test/modules/brin has some brin related tests, so > I thought that src/test/modules/alter_table might be the spot, but > after looking at src/test/README I see it mentions that only tests > that are themselves an extension should be located within: > > modules/ > Extensions used only or mainly for test purposes, generally not suitable > for installing in production databases > > There are a few others in the same situation as brin; commit_ts, > snapshot_too_old, unsafe_tests. I see unsafe_tests does mention the > lack of module in the README file.
The readme in src/test/modules says "extensions or libraries", and I see no reason to think that a TAP test would be totally out of place there. I think the alter_table/ subdir is a perfect place. Sergei, can we enlist you to submit a patch for this? Namely reduce the log level to DEBUG1 and add a TAP test in src/test/modules/alter_table/ that verifies that the message is or isn't emitted, as appropriate. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
