Hello pgdevs,
The attached patch improves pgbench variable management as discussed in: https://www.postgresql.org/message-id/flat/alpine.DEB.2.21.1904081752210.5867@lancreAs discussed there as well, the overall effect is small compared to libpq & system costs when pgbench is talking to a postgres server. When someone says "pgbench is slow", they really mean "libpq & <my-system> are slow", because pgbench does not do much beyond jumping from one libpq call to the next. Anyway, the patch has a measurable positive effect.
### Rework pgbench variables and associated values for better performance - a (hopefully) thread-safe symbol table which maps variable names to integers note that all variables are statically known, but \gset stuff. - numbers are then used to access per-client arrays The symbol table stores names as distinct leaves in a tree on bytes. Each symbol name is the shortest-prefix leaf, possibly including the final '\0'. Some windows-specific hacks are note tested. File "symbol_table_test.c" does what it says and can be compiled standalone. Most malloc/free cycles are taken out of running a benchmark: - there is a (large?) maximum number of variables of 32*MAX_SCRIPTS - variable names and string values are statically allocated, and limited to, 64 bytes - a per-client persistent buffer is used for various purpose, to avoid mallocs/frees. Functions assignVariables & parseQuery basically shared the same variable substitution logic, but differed in what was substituted. The logic has been abstracted into a common function.This patch brings pgbench-specific overheads down on some tests, one thread one client, on my laptop, with the attached scripts, in tps:
- set_x_1.sql: 11.1M -> 14.2M - sets.sql: 0.8M -> 2.7M # 20 \set - set.sql: 1.5M -> 2.0M # 3 \set & "complex" expressions - empty.sql: 63.9K -> 64.1K (…) - select_aid.sql: 29.3K -> 29.3K - select_aids.sql: 23.4K -> 24.2K - gset_aid.sql: 28.3K -> 29.2K So we are talking significant improvements on pgbench-only scripts, onlya few percents once pgbench must interact with a CPU-bound server, because time is spent elsewhere.
-- Fabien.
empty.sql
Description: application/sql
select_aids.sql
Description: application/sql
select_aid.sql
Description: application/sql
diff --git a/src/bin/pgbench/Makefile b/src/bin/pgbench/Makefile
index 25abd0a875..39bba12c23 100644
--- a/src/bin/pgbench/Makefile
+++ b/src/bin/pgbench/Makefile
@@ -7,7 +7,7 @@ subdir = src/bin/pgbench
top_builddir = ../../..
include $(top_builddir)/src/Makefile.global
-OBJS = pgbench.o exprparse.o $(WIN32RES)
+OBJS = pgbench.o exprparse.o symbol_table.o $(WIN32RES)
override CPPFLAGS := -I. -I$(srcdir) -I$(libpq_srcdir) $(CPPFLAGS)
LDFLAGS_INTERNAL += -L$(top_builddir)/src/fe_utils -lpgfeutils $(libpq_pgport)
diff --git a/src/bin/pgbench/exprparse.y b/src/bin/pgbench/exprparse.y
index 17c9ec32c5..8c4ad7eff3 100644
--- a/src/bin/pgbench/exprparse.y
+++ b/src/bin/pgbench/exprparse.y
@@ -211,7 +211,7 @@ make_variable(char *varname)
PgBenchExpr *expr = pg_malloc(sizeof(PgBenchExpr));
expr->etype = ENODE_VARIABLE;
- expr->u.variable.varname = varname;
+ expr->u.variable.varnum = getOrCreateSymbolId(symbol_table, varname);
return expr;
}
diff --git a/src/bin/pgbench/exprscan.l b/src/bin/pgbench/exprscan.l
index e9020ad231..1c80e5cac6 100644
--- a/src/bin/pgbench/exprscan.l
+++ b/src/bin/pgbench/exprscan.l
@@ -207,19 +207,19 @@ notnull [Nn][Oo][Tt][Nn][Uu][Ll][Ll]
{digit}+ {
if (!strtoint64(yytext, true, &yylval->ival))
expr_yyerror_more(yyscanner, "bigint constant overflow",
- strdup(yytext));
+ pg_strdup(yytext));
return INTEGER_CONST;
}
{digit}+(\.{digit}*)?([eE][-+]?{digit}+)? {
if (!strtodouble(yytext, true, &yylval->dval))
expr_yyerror_more(yyscanner, "double constant overflow",
- strdup(yytext));
+ pg_strdup(yytext));
return DOUBLE_CONST;
}
\.{digit}+([eE][-+]?{digit}+)? {
if (!strtodouble(yytext, true, &yylval->dval))
expr_yyerror_more(yyscanner, "double constant overflow",
- strdup(yytext));
+ pg_strdup(yytext));
return DOUBLE_CONST;
}
{alpha}{alnum}* {
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
index 570cf3306a..8025be302d 100644
--- a/src/bin/pgbench/pgbench.c
+++ b/src/bin/pgbench/pgbench.c
@@ -232,24 +232,30 @@ const char *progname;
volatile bool timer_exceeded = false; /* flag from signal handler */
/*
- * Variable definitions.
+ * Variable contents.
+ *
+ * Variable names are managed in symbol_table with a number.
*
* If a variable only has a string value, "svalue" is that value, and value is
- * "not set". If the value is known, "value" contains the value (in any
- * variant).
+ * "not set".
+ *
+ * If the value is known, "value" contains the value (in any variant).
*
* In this case "svalue" contains the string equivalent of the value, if we've
- * had occasion to compute that, or NULL if we haven't.
+ * had occasion to compute that, or an empty string if we haven't.
*/
+#define SVALUE_SIZE 64
typedef struct
{
- char *name; /* variable's name */
- char *svalue; /* its value in string form, if known */
- PgBenchValue value; /* actual variable's value */
+ int number; /* variable symbol number, -1 if unset */
+ char svalue[SVALUE_SIZE]; /* value in string form, if known */
+ PgBenchValue value; /* actual value, if known */
} Variable;
+#define undefined_variable_value(v) \
+ v.svalue[0] == '\0' && v.value.type == PGBT_NO_VALUE
+
#define MAX_SCRIPTS 128 /* max number of SQL scripts allowed */
-#define SHELL_COMMAND_SIZE 256 /* maximum size allowed for shell command */
/*
* Simple data structure to keep stats about something.
@@ -395,7 +401,6 @@ typedef struct
/* client variables */
Variable *variables; /* array of variable definitions */
int nvariables; /* number of variables */
- bool vars_sorted; /* are variables sorted by name? */
/* various times about current transaction */
int64 txn_scheduled; /* scheduled start time of transaction (usec) */
@@ -408,6 +413,9 @@ typedef struct
/* per client collected stats */
int64 cnt; /* client transaction count, for -t */
int ecnt; /* error count */
+
+ /* next buffer should be at thread level, but it would change functions... */
+ PQExpBufferData buf; /* persistant buffer to avoid malloc/free cycles */
} CState;
/*
@@ -493,6 +501,7 @@ static const char *QUERYMODE[] = {"simple", "extended", "prepared"};
* varprefix SQL commands terminated with \gset have this set
* to a non NULL value. If nonempty, it's used to prefix the
* variable name that receives the value.
+ * set_varnum variable symbol number for \set and \setshell.
* expr Parsed expression, if needed.
* stats Time spent in this command.
*/
@@ -505,6 +514,7 @@ typedef struct Command
int argc;
char *argv[MAX_ARGS];
char *varprefix;
+ int set_varnum;
PgBenchExpr *expr;
SimpleStats stats;
} Command;
@@ -523,6 +533,9 @@ static int64 total_weight = 0;
static int debug = 0; /* debug flag */
+#define MAX_VARIABLES (32 * MAX_SCRIPTS)
+SymbolTable symbol_table = NULL; /* also used by exprparse.y */
+
/* Builtin test scripts */
typedef struct BuiltinScript
{
@@ -666,7 +679,7 @@ usage(void)
/* return whether str matches "^\s*[-+]?[0-9]+$" */
static bool
-is_an_int(const char *str)
+is_an_int(const char *str, bool allow_end_spaces)
{
const char *ptr = str;
@@ -686,6 +699,10 @@ is_an_int(const char *str)
while (*ptr && isdigit((unsigned char) *ptr))
ptr++;
+ if (allow_end_spaces)
+ while (*ptr && isspace((unsigned char) *ptr))
+ ptr++;
+
/* must have reached end of string */
return *ptr == '\0';
}
@@ -1215,71 +1232,39 @@ doConnect(void)
return conn;
}
-/* qsort comparator for Variable array */
-static int
-compareVariableNames(const void *v1, const void *v2)
-{
- return strcmp(((const Variable *) v1)->name,
- ((const Variable *) v2)->name);
-}
-
-/* Locate a variable by name; returns NULL if unknown */
-static Variable *
-lookupVariable(CState *st, char *name)
-{
- Variable key;
-
- /* On some versions of Solaris, bsearch of zero items dumps core */
- if (st->nvariables <= 0)
- return NULL;
-
- /* Sort if we have to */
- if (!st->vars_sorted)
- {
- qsort((void *) st->variables, st->nvariables, sizeof(Variable),
- compareVariableNames);
- st->vars_sorted = true;
- }
-
- /* Now we can search */
- key.name = name;
- return (Variable *) bsearch((void *) &key,
- (void *) st->variables,
- st->nvariables,
- sizeof(Variable),
- compareVariableNames);
-}
-
/* Get the value of a variable, in string form; returns NULL if unknown */
static char *
-getVariable(CState *st, char *name)
+getVariable(CState *st, const char *name)
{
+ int num = getSymbolId(symbol_table, name);
Variable *var;
- char stringform[64];
- var = lookupVariable(st, name);
- if (var == NULL)
- return NULL; /* not found */
+ if (num < 0 || st->nvariables <= num)
+ return NULL; /* not found */
- if (var->svalue)
+ var = & st->variables[num];
+
+ if (var->svalue[0] != '\0')
return var->svalue; /* we have it in string form */
/* We need to produce a string equivalent of the value */
Assert(var->value.type != PGBT_NO_VALUE);
- if (var->value.type == PGBT_NULL)
- snprintf(stringform, sizeof(stringform), "NULL");
- else if (var->value.type == PGBT_BOOLEAN)
- snprintf(stringform, sizeof(stringform),
- "%s", var->value.u.bval ? "true" : "false");
- else if (var->value.type == PGBT_INT)
- snprintf(stringform, sizeof(stringform),
+ if (var->value.type == PGBT_INT)
+ /* we could call fmtint() directly if available */
+ snprintf(var->svalue, SVALUE_SIZE,
INT64_FORMAT, var->value.u.ival);
+ else if (var->value.type == PGBT_NULL)
+ strcpy(var->svalue, "NULL");
+ else if (var->value.type == PGBT_BOOLEAN)
+ strcpy(var->svalue, var->value.u.bval ? "true" : "false");
else if (var->value.type == PGBT_DOUBLE)
- snprintf(stringform, sizeof(stringform),
+ /* we could call fmtfloat() directly if available */
+ snprintf(var->svalue, SVALUE_SIZE,
"%.*g", DBL_DIG, var->value.u.dval);
- else /* internal error, unexpected type */
+ else
+ /* internal error, unexpected type */
Assert(0);
- var->svalue = pg_strdup(stringform);
+
return var->svalue;
}
@@ -1292,17 +1277,26 @@ makeVariableValue(Variable *var)
if (var->value.type != PGBT_NO_VALUE)
return true; /* no work */
+ if (var->svalue[0] == '\0')
+ return false;
+
slen = strlen(var->svalue);
- if (slen == 0)
- /* what should it do on ""? */
- return false;
+ /* try most probable first */
+ if (is_an_int(var->svalue, false))
+ {
+ /* if it looks like an int, it must be an int without overflow */
+ int64 iv;
- if (pg_strcasecmp(var->svalue, "null") == 0)
+ if (!strtoint64(var->svalue, false, &iv))
+ return false;
+
+ setIntValue(&var->value, iv);
+ }
+ else if (pg_strcasecmp(var->svalue, "null") == 0)
{
setNullValue(&var->value);
}
-
/*
* accept prefixes such as y, ye, n, no... but not for "o". 0/1 are
* recognized later as an int, which is converted to bool if needed.
@@ -1320,25 +1314,16 @@ makeVariableValue(Variable *var)
{
setBoolValue(&var->value, false);
}
- else if (is_an_int(var->svalue))
- {
- /* if it looks like an int, it must be an int without overflow */
- int64 iv;
-
- if (!strtoint64(var->svalue, false, &iv))
- return false;
-
- setIntValue(&var->value, iv);
- }
else /* type should be double */
{
double dv;
if (!strtodouble(var->svalue, true, &dv))
{
- fprintf(stderr,
- "malformed variable \"%s\" value: \"%s\"\n",
- var->name, var->svalue);
+ /* well, it is not */
+ fprintf(stderr, "malformed variable \"%s\" value: \"%s\"\n",
+ var->number >= 0 ? getSymbolName(symbol_table, var->number) : "<null>",
+ var->svalue);
return false;
}
setDoubleValue(&var->value, dv);
@@ -1381,204 +1366,217 @@ valid_variable_name(const char *name)
}
/*
- * Lookup a variable by name, creating it if need be.
- * Caller is expected to assign a value to the variable.
- * Returns NULL on failure (bad name).
+ * Assign a string value to a variable, creating it if need be.
+ *
+ * For parsed expressions and \set variable names are already known, and
+ * switched to their symbol number.
+ *
+ * This routine is only used for possibly unknown variables names resulting from
+ * \gset and from option -D. For the former case which would be repeated often,
+ * we could do a switch on first execution, which would require some additional
+ * data structure.
+ *
+ * Returns false on failure (too many variables, bad name)
*/
-static Variable *
-lookupCreateVariable(CState *st, const char *context, char *name)
+static bool
+putVariable(CState *st, const char *context, char *name, const char *value)
{
+ int num = getOrCreateSymbolId(symbol_table, name);
Variable *var;
- var = lookupVariable(st, name);
- if (var == NULL)
+ if (num < 0 || st->nvariables <= num)
{
- Variable *newvars;
+ fprintf(stderr, "%s: too many variables while adding \"%s\"\n",
+ context, name);
+ return false;
+ }
- /*
- * Check for the name only when declaring a new variable to avoid
- * overhead.
- */
+ var = & st->variables[num];
+
+ if (unlikely(var->number == -1))
+ {
+ /* first time the variable is encountered, do some checks */
if (!valid_variable_name(name))
{
- fprintf(stderr, "%s: invalid variable name: \"%s\"\n",
+ fprintf(stderr, "%s: invalid variable name \"%s\"\n",
context, name);
- return NULL;
+ return false;
}
- /* Create variable at the end of the array */
- if (st->variables)
- newvars = (Variable *) pg_realloc(st->variables,
- (st->nvariables + 1) * sizeof(Variable));
- else
- newvars = (Variable *) pg_malloc(sizeof(Variable));
-
- st->variables = newvars;
-
- var = &newvars[st->nvariables];
-
- var->name = pg_strdup(name);
- var->svalue = NULL;
- /* caller is expected to initialize remaining fields */
-
- st->nvariables++;
- /* we don't re-sort the array till we have to */
- st->vars_sorted = false;
+ var->number = num;
}
- return var;
-}
-
-/* Assign a string value to a variable, creating it if need be */
-/* Returns false on failure (bad name) */
-static bool
-putVariable(CState *st, const char *context, char *name, const char *value)
-{
- Variable *var;
- char *val;
-
- var = lookupCreateVariable(st, context, name);
- if (!var)
+ if (unlikely(strlen(value) >= SVALUE_SIZE))
+ {
+ /* we could truncate with a warning? */
+ fprintf(stderr, "%s: \"%s\" value is too long (\"%s\")\n",
+ context, name, value);
return false;
+ }
- /* dup then free, in case value is pointing at this variable */
- val = pg_strdup(value);
-
- if (var->svalue)
- free(var->svalue);
- var->svalue = val;
+ strncpy(var->svalue, value, SVALUE_SIZE);
var->value.type = PGBT_NO_VALUE;
return true;
}
-/* Assign a value to a variable, creating it if need be */
-/* Returns false on failure (bad name) */
+/* shortcut version if variable number is known */
static bool
-putVariableValue(CState *st, const char *context, char *name,
- const PgBenchValue *value)
+putSymbolValue(CState *st, const char *context, int var_num,
+ const PgBenchValue *value)
{
- Variable *var;
+ Variable *var;
- var = lookupCreateVariable(st, context, name);
- if (!var)
+ if (var_num < 0 || var_num >= st->nvariables)
+ {
+ fprintf(stderr, "%s: unexpected variable number %d\n",
+ context, var_num);
return false;
+ }
- if (var->svalue)
- free(var->svalue);
- var->svalue = NULL;
+ var = & st->variables[var_num];
+
+ if (unlikely(var->number == -1))
+ var->number = var_num;
+
+ var->svalue[0] = '\0';
var->value = *value;
return true;
}
-/* Assign an integer value to a variable, creating it if need be */
-/* Returns false on failure (bad name) */
+/* shortcut version with variable number */
static bool
-putVariableInt(CState *st, const char *context, char *name, int64 value)
+putSymbolInt(CState *st, const char *context, int var_num, int64 value)
{
- PgBenchValue val;
+ Variable *var;
- setIntValue(&val, value);
- return putVariableValue(st, context, name, &val);
+ if (var_num < 0 || var_num >= st->nvariables)
+ {
+ fprintf(stderr, "%s: unexpected variable number %d\n",
+ context, var_num);
+ return false;
+ }
+
+ var = & st->variables[var_num];
+
+ if (unlikely(var->number == -1))
+ var->number = var_num;
+
+ var->svalue[0] = '\0';
+ setIntValue(&var->value, value);
+
+ return true;
}
+#define MAX_VARNAME_LENGTH 64 /* in bytes, whatever encoding */
+
/*
- * Parse a possible variable reference (:varname).
+ * Parse a possible variable reference (:varname), starting after the ':'.
*
- * "sql" points at a colon. If what follows it looks like a valid
- * variable name, return a malloc'd string containing the variable name,
- * and set *eaten to the number of characters consumed.
- * Otherwise, return NULL.
+ * return the number of bytes parsed, possibly zero, and the name.
*/
-static char *
-parseVariable(const char *sql, int *eaten)
+static int
+parseVariable(const char *sql, char name[MAX_VARNAME_LENGTH])
{
int i = 0;
- char *name;
- do
- {
- i++;
- } while (IS_HIGHBIT_SET(sql[i]) ||
- strchr("ABCDEFGHIJKLMNOPQRSTUVWXYZ" "abcdefghijklmnopqrstuvwxyz"
- "_0123456789", sql[i]) != NULL);
- if (i == 1)
- return NULL; /* no valid variable name chars */
-
- name = pg_malloc(i);
- memcpy(name, &sql[1], i - 1);
- name[i - 1] = '\0';
-
- *eaten = i;
- return name;
-}
+ while (i < MAX_VARNAME_LENGTH &&
+ (IS_HIGHBIT_SET(sql[i]) ||
+ strchr("ABCDEFGHIJKLMNOPQRSTUVWXYZ" "abcdefghijklmnopqrstuvwxyz"
+ "_0123456789", sql[i]) != NULL))
+ name[i] = sql[i], i++;
-static char *
-replaceVariable(char **sql, char *param, int len, char *value)
-{
- int valueln = strlen(value);
-
- if (valueln > len)
+ if (i == MAX_VARNAME_LENGTH)
{
- size_t offset = param - *sql;
-
- *sql = pg_realloc(*sql, strlen(*sql) - len + valueln + 1);
- param = *sql + offset;
+ fprintf(stderr, "variable name is too long: %s\n", sql);
+ /* ignore? abort? error handling? */
+ return 0;
}
- if (valueln != len)
- memmove(param + valueln, param + len, strlen(param + len) + 1);
- memcpy(param, value, valueln);
-
- return param + valueln;
+ name[i] = '\0';
+ return i;
}
-static char *
-assignVariables(CState *st, char *sql)
+
+/*
+ * Substitutes :vars inside sql into buf, in quite a primitive way.
+ *
+ * Although the SQL query has been cleanly tokenized, there is
+ * no memory of that here, so that substitutions would be performed
+ * within a string or comment.
+ */
+static void
+substituteVariables(PQExpBufferData *buf, const char *sql,
+ char *(name2val)(void *, const char * name), void *ctx)
{
char *p,
- *name,
- *val;
+ *start;
- p = sql;
+ resetPQExpBuffer(buf);
+
+ start = p = (char *) sql;
while ((p = strchr(p, ':')) != NULL)
{
- int eaten;
+ char name[MAX_VARNAME_LENGTH];
+ int namelen;
+ char *val;
- name = parseVariable(p, &eaten);
- if (name == NULL)
+ /* look for a possible variable name */
+ namelen = parseVariable(p+1, name);
+
+ if (namelen == 0)
{
- while (*p == ':')
- {
+ /* skip leading ':' */
+ do {
p++;
- }
- continue;
+ } while (*p == ':');
}
- val = getVariable(st, name);
- free(name);
- if (val == NULL)
- {
- p++;
+ /* append verbatim */
+ appendBinaryPQExpBuffer(buf, start, p-start);
+ start = p;
+
+ if (namelen == 0)
+ /* no :variable, let us look for another :name */
continue;
- }
- p = replaceVariable(&sql, p, eaten, val);
+ /* we have a name, is there an associated value? */
+ val = name2val(ctx, name);
+
+ if (val != NULL)
+ appendPQExpBufferStr(buf, val);
+ else
+ /* no value, coldly insert :name */
+ appendBinaryPQExpBuffer(buf, start, namelen+1);
+
+ /* skip name and proceed */
+ start += namelen + 1;
+ p = start;
}
- return sql;
+ /* append end of string */
+ appendPQExpBufferStr(buf, start);
}
+
+/* substitutes :vars inside sql by their value into buf */
+static void
+assignVariables(CState *st, const char *sql)
+{
+ substituteVariables(&st->buf, sql,
+ (char *(*)(void *, const char *)) getVariable, st);
+}
+
+/* get the string value of all parameters */
static void
getQueryParams(CState *st, const Command *command, const char **params)
{
- int i;
-
- for (i = 0; i < command->argc - 1; i++)
+ for (int i = 0; i < command->argc - 1; i++)
params[i] = getVariable(st, command->argv[i + 1]);
}
+/* for debug display, return type name of value */
static char *
valueTypeName(PgBenchValue *pval)
{
@@ -1722,6 +1720,7 @@ setDoubleValue(PgBenchValue *pv, double dval)
pv->u.dval = dval;
}
+/* functions and operators which have a lazy evaluation */
static bool
isLazyFunc(PgBenchFunction func)
{
@@ -1781,8 +1780,6 @@ evalLazyFunc(CState *st,
return true;
}
- return true;
-
case PGBENCH_OR:
if (a1.type == PGBT_NULL)
@@ -1828,7 +1825,7 @@ evalLazyFunc(CState *st,
if (args->next == NULL)
return evaluateExpr(st, args->expr, retval);
- /* no, another when, proceed */
+ /* no, another when, proceed recursively */
return evalLazyFunc(st, PGBENCH_CASE, args, retval);
default:
@@ -2423,16 +2420,18 @@ evaluateExpr(CState *st, PgBenchExpr *expr, PgBenchValue *retval)
case ENODE_VARIABLE:
{
Variable *var;
+ int num = expr->u.variable.varnum;
- if ((var = lookupVariable(st, expr->u.variable.varname)) == NULL)
- {
- fprintf(stderr, "undefined variable \"%s\"\n",
- expr->u.variable.varname);
- return false;
- }
+ Assert(0 <= num && num < st->nvariables);
+
+ var = & st->variables[num];
if (!makeVariableValue(var))
+ {
+ fprintf(stderr, "no value for variable \"%s\"\n",
+ getSymbolName(symbol_table, num));
return false;
+ }
*retval = var->value;
return true;
@@ -2486,19 +2485,16 @@ getMetaCommand(const char *cmd)
}
/*
- * Run a shell command. The result is assigned to the variable if not NULL.
+ * Run a shell command. The result is assigned to the variable if != -1.
* Return true if succeeded, or false on error.
*/
static bool
-runShellCommand(CState *st, char *variable, char **argv, int argc)
+runShellCommand(CState *st, int var_num, char **argv, int argc)
{
- char command[SHELL_COMMAND_SIZE];
- int i,
- len = 0;
FILE *fp;
char res[64];
- char *endptr;
- int retval;
+
+ resetPQExpBuffer(& st->buf);
/*----------
* Join arguments with whitespace separators. Arguments starting with
@@ -2508,10 +2504,9 @@ runShellCommand(CState *st, char *variable, char **argv, int argc)
* ::name - append a string ":name"
*----------
*/
- for (i = 0; i < argc; i++)
+ for (int i = 0; i < argc; i++)
{
char *arg;
- int arglen;
if (argv[i][0] != ':')
{
@@ -2528,25 +2523,14 @@ runShellCommand(CState *st, char *variable, char **argv, int argc)
return false;
}
- arglen = strlen(arg);
- if (len + arglen + (i > 0 ? 1 : 0) >= SHELL_COMMAND_SIZE - 1)
- {
- fprintf(stderr, "%s: shell command is too long\n", argv[0]);
- return false;
- }
-
- if (i > 0)
- command[len++] = ' ';
- memcpy(command + len, arg, arglen);
- len += arglen;
+ appendPQExpBufferStr(& st->buf, arg);
+ appendPQExpBufferChar(& st->buf, ' ');
}
- command[len] = '\0';
-
/* Fast path for non-assignment case */
- if (variable == NULL)
+ if (var_num == -1)
{
- if (system(command))
+ if (system(st->buf.data) != 0)
{
if (!timer_exceeded)
fprintf(stderr, "%s: could not launch shell command\n", argv[0]);
@@ -2556,7 +2540,7 @@ runShellCommand(CState *st, char *variable, char **argv, int argc)
}
/* Execute the command with pipe and read the standard output. */
- if ((fp = popen(command, "r")) == NULL)
+ if ((fp = popen(st->buf.data, "r")) == NULL)
{
fprintf(stderr, "%s: could not launch shell command\n", argv[0]);
return false;
@@ -2575,17 +2559,22 @@ runShellCommand(CState *st, char *variable, char **argv, int argc)
}
/* Check whether the result is an integer and assign it to the variable */
- retval = (int) strtol(res, &endptr, 10);
- while (*endptr != '\0' && isspace((unsigned char) *endptr))
- endptr++;
- if (*res == '\0' || *endptr != '\0')
+ if (is_an_int(res, true))
+ {
+ int64 retval;
+
+ if (!strtoint64(res, false, &retval))
+ return false;
+
+ if (!putSymbolInt(st, "setshell", var_num, retval))
+ return false;
+ }
+ else
{
fprintf(stderr, "%s: shell command must return an integer (not \"%s\")\n",
argv[0], res);
return false;
}
- if (!putVariableInt(st, "setshell", variable, retval))
- return false;
#ifdef DEBUG
printf("shell parameter name: \"%s\", value: \"%s\"\n", argv[1], res);
@@ -2635,15 +2624,11 @@ sendCommand(CState *st, Command *command)
if (querymode == QUERY_SIMPLE)
{
- char *sql;
-
- sql = pg_strdup(command->argv[0]);
- sql = assignVariables(st, sql);
+ assignVariables(st, command->argv[0]);
if (debug)
- fprintf(stderr, "client %d sending %s\n", st->id, sql);
- r = PQsendQuery(st->con, sql);
- free(sql);
+ fprintf(stderr, "client %d sending %s\n", st->id, st->buf.data);
+ r = PQsendQuery(st->con, st->buf.data);
}
else if (querymode == QUERY_EXTENDED)
{
@@ -2662,6 +2647,7 @@ sendCommand(CState *st, Command *command)
char name[MAX_PREPARE_NAME];
const char *params[MAX_ARGS];
+ /* prepare the first time it is needed */
if (!st->prepared[st->use_file])
{
int j;
@@ -2761,13 +2747,16 @@ readCommandResponse(CState *st, char *varprefix)
{
char *varname = PQfname(res, fld);
- /* allocate varname only if necessary, freed below */
if (*varprefix != '\0')
- varname = psprintf("%s%s", varprefix, varname);
+ {
+ resetPQExpBuffer(&st->buf);
+ appendPQExpBufferStr(&st->buf, varprefix);
+ appendPQExpBufferStr(&st->buf, varname);
+ varname = st->buf.data;
+ }
/* store result as a string */
- if (!putVariable(st, "gset", varname,
- PQgetvalue(res, 0, fld)))
+ if (!putVariable(st, "gset", varname, PQgetvalue(res, 0, fld)))
{
/* internal error */
fprintf(stderr,
@@ -2776,9 +2765,6 @@ readCommandResponse(CState *st, char *varprefix)
varname);
goto error;
}
-
- if (*varprefix != '\0')
- pg_free(varname);
}
}
/* otherwise the result is simply thrown away by PQclear below */
@@ -2827,18 +2813,18 @@ error:
static bool
evaluateSleep(CState *st, int argc, char **argv, int *usecs)
{
- char *var;
int usec;
if (*argv[1] == ':')
{
- if ((var = getVariable(st, argv[1] + 1)) == NULL)
+ char *val;
+ if ((val = getVariable(st, argv[1] + 1)) == NULL)
{
fprintf(stderr, "%s: undefined variable \"%s\"\n",
argv[0], argv[1]);
return false;
}
- usec = atoi(var);
+ usec = atoi(val);
}
else
usec = atoi(argv[1]);
@@ -2849,6 +2835,7 @@ evaluateSleep(CState *st, int argc, char **argv, int *usecs)
usec *= 1000;
else if (pg_strcasecmp(argv[2], "s") == 0)
usec *= 1000000;
+ /* else there should be an error? */
}
else
usec *= 1000000;
@@ -3344,7 +3331,7 @@ executeMetaCommand(CState *st, instr_time *now)
return CSTATE_ABORTED;
}
- if (!putVariableValue(st, argv[0], argv[1], &result))
+ if (!putSymbolValue(st, argv[0], command->set_varnum, &result))
{
commandFailed(st, "set", "assignment of meta-command failed");
return CSTATE_ABORTED;
@@ -3414,7 +3401,7 @@ executeMetaCommand(CState *st, instr_time *now)
}
else if (command->meta == META_SETSHELL)
{
- if (!runShellCommand(st, argv[1], argv + 2, argc - 2))
+ if (!runShellCommand(st, command->set_varnum, argv + 2, argc - 2))
{
commandFailed(st, "setshell", "execution of meta-command failed");
return CSTATE_ABORTED;
@@ -3422,7 +3409,7 @@ executeMetaCommand(CState *st, instr_time *now)
}
else if (command->meta == META_SHELL)
{
- if (!runShellCommand(st, NULL, argv + 1, argc - 1))
+ if (!runShellCommand(st, -1, argv + 1, argc - 1))
{
commandFailed(st, "shell", "execution of meta-command failed");
return CSTATE_ABORTED;
@@ -4010,57 +3997,57 @@ runInitSteps(const char *initialize_steps)
termPQExpBuffer(&stats);
}
+/* parseQuery helper struct */
+typedef struct {
+ char value[13];
+ Command *cmd;
+ bool ok;
+} NumberContext;
+
+/* parseQuery helper function to generate "$<i>"*/
+static char *
+genDollarN(NumberContext *ctx, const char *name)
+{
+ Command *cmd = ctx->cmd;
+
+ if (unlikely(cmd->argc >= MAX_ARGS))
+ {
+ fprintf(stderr,
+ "statement has too many arguments (maximum is %d): %s\n",
+ MAX_ARGS - 1, cmd->lines.data);
+ ctx->ok = false;
+ return NULL;
+ }
+ sprintf(ctx->value, "$%d", cmd->argc);
+ cmd->argv[cmd->argc] = pg_strdup(name);
+ cmd->argc++;
+ return ctx->value;
+}
+
/*
* Replace :param with $n throughout the command's SQL text, which
* is a modifiable string in cmd->lines.
+ *
+ * The substituted query is hold in argv[0] and subsequent argv's hold
+ * variable names.
*/
static bool
parseQuery(Command *cmd)
{
- char *sql,
- *p;
+ NumberContext ctx = { "", cmd, true };
+ PQExpBufferData buf;
+ initPQExpBuffer(&buf);
cmd->argc = 1;
- p = sql = pg_strdup(cmd->lines.data);
- while ((p = strchr(p, ':')) != NULL)
- {
- char var[13];
- char *name;
- int eaten;
-
- name = parseVariable(p, &eaten);
- if (name == NULL)
- {
- while (*p == ':')
- {
- p++;
- }
- continue;
- }
-
- /*
- * cmd->argv[0] is the SQL statement itself, so the max number of
- * arguments is one less than MAX_ARGS
- */
- if (cmd->argc >= MAX_ARGS)
- {
- fprintf(stderr, "statement has too many arguments (maximum is %d): %s\n",
- MAX_ARGS - 1, cmd->lines.data);
- pg_free(name);
- return false;
- }
-
- sprintf(var, "$%d", cmd->argc);
- p = replaceVariable(&sql, p, eaten, var);
-
- cmd->argv[cmd->argc] = name;
- cmd->argc++;
- }
+ substituteVariables(&buf, cmd->lines.data,
+ (char *(*)(void *, const char *)) genDollarN, &ctx);
Assert(cmd->argv[0] == NULL);
- cmd->argv[0] = sql;
- return true;
+ cmd->argv[0] = pg_strdup(buf.data);
+
+ termPQExpBuffer(&buf);
+ return ctx.ok;
}
/*
@@ -4280,6 +4267,12 @@ process_backslash_command(PsqlScanState sstate, const char *source)
offsets[j] = word_offset;
my_command->argv[j++] = pg_strdup(word_buf.data);
my_command->argc++;
+
+ if (!valid_variable_name(word_buf.data))
+ syntax_error(source, lineno, my_command->first_line, my_command->argv[0],
+ "invalid variable name", word_buf.data, -1);
+
+ my_command->set_varnum = getOrCreateSymbolId(symbol_table, word_buf.data);
}
/* then for all parse the expression */
@@ -4377,6 +4370,12 @@ process_backslash_command(PsqlScanState sstate, const char *source)
if (my_command->argc < 3)
syntax_error(source, lineno, my_command->first_line, my_command->argv[0],
"missing argument", NULL, -1);
+
+ if (!valid_variable_name(my_command->argv[1]))
+ syntax_error(source, lineno, my_command->first_line, my_command->argv[0],
+ "invalid variable name", my_command->argv[1], -1);
+
+ my_command->set_varnum = getOrCreateSymbolId(symbol_table, my_command->argv[1]);
}
else if (my_command->meta == META_SHELL)
{
@@ -5152,8 +5151,9 @@ main(int argc, char **argv)
StatsData stats;
int weight;
- int i;
int nclients_dealt;
+ int scale_symbol, client_id_symbol,
+ random_seed_symbol, default_seed_symbol;
#ifdef HAVE_GETRLIMIT
struct rlimit rlim;
@@ -5190,6 +5190,22 @@ main(int argc, char **argv)
login = env;
state = (CState *) pg_malloc0(sizeof(CState));
+ state->nvariables = MAX_VARIABLES;
+ state->variables = pg_malloc(sizeof(Variable) * state->nvariables);
+ for (int i = 0; i < state->nvariables; i++)
+ {
+ state->variables[i].number = -1;
+ memset(state->variables[i].svalue, 0, SVALUE_SIZE);
+ state->variables[i].value.type = PGBT_NO_VALUE;
+ }
+ initPQExpBuffer(&state->buf);
+
+ /* symbol table */
+ symbol_table = newSymbolTable();
+ scale_symbol = getOrCreateSymbolId(symbol_table, "scale");
+ client_id_symbol = getOrCreateSymbolId(symbol_table, "client_id");
+ random_seed_symbol = getOrCreateSymbolId(symbol_table, "random_seed");
+ default_seed_symbol = getOrCreateSymbolId(symbol_table, "default_seed");
/* set random seed early, because it may be used while parsing scripts. */
if (!set_random_seed(getenv("PGBENCH_RANDOM_SEED")))
@@ -5502,7 +5518,7 @@ main(int argc, char **argv)
}
/* complete SQL command initialization and compute total weight */
- for (i = 0; i < num_scripts; i++)
+ for (int i = 0; i < num_scripts; i++)
{
Command **commands = sql_script[i].commands;
@@ -5660,34 +5676,19 @@ main(int argc, char **argv)
state = (CState *) pg_realloc(state, sizeof(CState) * nclients);
memset(state + 1, 0, sizeof(CState) * (nclients - 1));
- /* copy any -D switch values to all clients */
- for (i = 1; i < nclients; i++)
+ for (int i = 1; i < nclients; i++)
{
- int j;
-
state[i].id = i;
- for (j = 0; j < state[0].nvariables; j++)
- {
- Variable *var = &state[0].variables[j];
-
- if (var->value.type != PGBT_NO_VALUE)
- {
- if (!putVariableValue(&state[i], "startup",
- var->name, &var->value))
- exit(1);
- }
- else
- {
- if (!putVariable(&state[i], "startup",
- var->name, var->svalue))
- exit(1);
- }
- }
+ state[i].nvariables = MAX_VARIABLES;
+ state[i].variables = pg_malloc(sizeof(Variable) * MAX_VARIABLES);
+ /* copy any -D switch values to all clients */
+ memcpy(state[i].variables, state[0].variables, sizeof(Variable) * MAX_VARIABLES);
+ initPQExpBuffer(&state[i].buf);
}
}
/* other CState initializations */
- for (i = 0; i < nclients; i++)
+ for (int i = 0; i < nclients; i++)
{
state[i].cstack = conditional_stack_create();
initRandomState(&state[i].cs_func_rs);
@@ -5754,43 +5755,41 @@ main(int argc, char **argv)
* :scale variables normally get -s or database scale, but don't override
* an explicit -D switch
*/
- if (lookupVariable(&state[0], "scale") == NULL)
+ if (undefined_variable_value(state[0].variables[scale_symbol]))
{
- for (i = 0; i < nclients; i++)
- {
- if (!putVariableInt(&state[i], "startup", "scale", scale))
+ for (int i = 0; i < nclients; i++)
+ if (!putSymbolInt(&state[i], "startup", scale_symbol, scale))
exit(1);
- }
}
/*
* Define a :client_id variable that is unique per connection. But don't
* override an explicit -D switch.
*/
- if (lookupVariable(&state[0], "client_id") == NULL)
+ if (undefined_variable_value(state[0].variables[client_id_symbol]))
{
- for (i = 0; i < nclients; i++)
- if (!putVariableInt(&state[i], "startup", "client_id", i))
+ for (int i = 0; i < nclients; i++)
+ if (!putSymbolInt(&state[i], "startup", client_id_symbol, i))
exit(1);
}
/* set default seed for hash functions */
- if (lookupVariable(&state[0], "default_seed") == NULL)
+ if (undefined_variable_value(state[0].variables[default_seed_symbol]))
{
uint64 seed =
((uint64) pg_jrand48(base_random_sequence.xseed) & 0xFFFFFFFF) |
(((uint64) pg_jrand48(base_random_sequence.xseed) & 0xFFFFFFFF) << 32);
- for (i = 0; i < nclients; i++)
- if (!putVariableInt(&state[i], "startup", "default_seed", (int64) seed))
+ for (int i = 0; i < nclients; i++)
+ if (!putSymbolInt(&state[i], "startup", default_seed_symbol, (int64) seed))
exit(1);
}
/* set random seed unless overwritten */
- if (lookupVariable(&state[0], "random_seed") == NULL)
+ if (undefined_variable_value(state[0].variables[random_seed_symbol]))
{
- for (i = 0; i < nclients; i++)
- if (!putVariableInt(&state[i], "startup", "random_seed", random_seed))
+ for (int i = 0; i < nclients; i++)
+ if (!putSymbolInt(&state[i], "startup", random_seed_symbol, random_seed))
exit(1);
}
@@ -5815,7 +5814,7 @@ main(int argc, char **argv)
threads = (TState *) pg_malloc(sizeof(TState) * nthreads);
nclients_dealt = 0;
- for (i = 0; i < nthreads; i++)
+ for (int i = 0; i < nthreads; i++)
{
TState *thread = &threads[i];
@@ -5845,7 +5844,7 @@ main(int argc, char **argv)
/* start threads */
#ifdef ENABLE_THREAD_SAFETY
- for (i = 0; i < nthreads; i++)
+ for (int i = 0; i < nthreads; i++)
{
TState *thread = &threads[i];
@@ -5884,7 +5883,7 @@ main(int argc, char **argv)
/* wait for threads and accumulate results */
initStats(&stats, 0);
INSTR_TIME_SET_ZERO(conn_total_time);
- for (i = 0; i < nthreads; i++)
+ for (int i = 0; i < nthreads; i++)
{
TState *thread = &threads[i];
@@ -5930,6 +5929,8 @@ main(int argc, char **argv)
if (exit_code != 0)
fprintf(stderr, "Run was aborted; the above results are incomplete.\n");
+ freeSymbolTable(symbol_table);
+
return exit_code;
}
diff --git a/src/bin/pgbench/pgbench.h b/src/bin/pgbench/pgbench.h
index c4a1e298e0..89a9314ac5 100644
--- a/src/bin/pgbench/pgbench.h
+++ b/src/bin/pgbench/pgbench.h
@@ -114,7 +114,7 @@ struct PgBenchExpr
PgBenchValue constant;
struct
{
- char *varname;
+ int varnum;
} variable;
struct
{
@@ -163,4 +163,21 @@ extern void syntax_error(const char *source, int lineno, const char *line,
extern bool strtoint64(const char *str, bool errorOK, int64 *pi);
extern bool strtodouble(const char *str, bool errorOK, double *pd);
+/*
+ * A symbol table is an opaque data structure
+ */
+struct SymbolTable_st;
+typedef struct SymbolTable_st *SymbolTable;
+
+SymbolTable newSymbolTable(void);
+void freeSymbolTable(SymbolTable st);
+void dumpSymbolTable(FILE *out, const char *msg, SymbolTable st);
+int numberOfSymbols(SymbolTable st);
+int getOrCreateSymbolId(SymbolTable st, const char *name);
+int getSymbolId(SymbolTable st, const char *name);
+char *getSymbolName(SymbolTable st, int number);
+int rmSymbolId(SymbolTable st, const char *name);
+
+extern SymbolTable symbol_table;
+
#endif /* PGBENCH_H */
diff --git a/src/bin/pgbench/symbol_table.c b/src/bin/pgbench/symbol_table.c
new file mode 100644
index 0000000000..56e7d5b7fc
--- /dev/null
+++ b/src/bin/pgbench/symbol_table.c
@@ -0,0 +1,359 @@
+/*
+ * src/bin/pgbench/symbol_table.c
+ *
+ * Copyright (c) 2000-2019, PostgreSQL Global Development Group
+ * ALL RIGHTS RESERVED;
+ *
+ * Permission to use, copy, modify, and distribute this software and its
+ * documentation for any purpose, without fee, and without a written agreement
+ * is hereby granted, provided that the above copyright notice and this
+ * paragraph and the following two paragraphs appear in all copies.
+ *
+ * IN NO EVENT SHALL THE AUTHOR OR DISTRIBUTORS BE LIABLE TO ANY PARTY FOR
+ * DIRECT, INDIRECT, SPECIAL, INCIDENTAL, OR CONSEQUENTIAL DAMAGES, INCLUDING
+ * LOST PROFITS, ARISING OUT OF THE USE OF THIS SOFTWARE AND ITS
+ * DOCUMENTATION, EVEN IF THE AUTHOR OR DISTRIBUTORS HAVE BEEN ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ * THE AUTHOR AND DISTRIBUTORS SPECIFICALLY DISCLAIMS ANY WARRANTIES,
+ * INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY
+ * AND FITNESS FOR A PARTICULAR PURPOSE. THE SOFTWARE PROVIDED HEREUNDER IS
+ * ON AN "AS IS" BASIS, AND THE AUTHOR AND DISTRIBUTORS HAS NO OBLIGATIONS TO
+ * PROVIDE MAINTENANCE, SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
+ */
+
+#include <stdlib.h>
+#include <stdio.h>
+#include <string.h>
+
+#ifdef WIN32
+#include <windows.h>
+#define pthread_mutex_t HANDLE
+#define pthread_mutex_init(m, p) *m = CreateMutex(NULL, FALSE, NULL)
+#define pthread_mutex_lock(m) WaitForSingleObject(*m, INFINITE)
+#define pthread_mutex_unlock(m) ReleaseMutex(*m)
+#define pthread_mutex_destroy(m) CloseHandle(*m)
+#elif defined(ENABLE_THREAD_SAFETY)
+#include <pthread.h>
+#else
+#define pthread_mutex_t void *
+#define pthread_mutex_init(m, p) 0
+#define pthread_mutex_lock(m)
+#define pthread_mutex_unlock(m)
+#define pthread_mutex_destroy(m)
+#endif
+
+#ifndef STANDALONE
+#include "postgres_fe.h"
+#include "pgbench.h"
+#endif
+
+/*----
+ *
+ * thread-safe simplistic symbol table management.
+ *
+ * Implement a string -> int table based on a tree on bytes.
+ * The data structure makes more sense if many searches are expected.
+ *
+ * Each '\0'-terminated string is store in the tree at the first non-unique
+ * byte prefix, possibly including the final '\0' if the string is a prefix of
+ * another name.
+ *
+ * Storage requirement n * strlen(s).
+ *
+ * Storing a symbol costs strlen(s) on average.
+ *
+ * Finding a symbol costs strlen(s).
+ *
+ * When symbols are removed, their slot is reused.
+ */
+
+typedef struct Symbol
+{
+ char *name;
+ int number;
+} Symbol;
+
+typedef struct SymbolTableNode
+{
+ enum { is_free, is_symb, is_tree } status;
+ union {
+ int symbol; /* is_free or is_symb */
+ struct SymbolTableNode *tree; /* is_tree */
+ } u;
+} SymbolTableNode;
+
+#define INITIAL_SYMBOL_SIZE 1
+
+struct SymbolTable_st
+{
+ int nsymbols; /* next symbol number */
+ int stored; /* current #symbols in table */
+ int next_avail; /* last removed symbol for reuse */
+ SymbolTableNode root; /* symbol tree root */
+ int symbols_size; /* size of following array */
+ Symbol *symbols; /* array of existing symbols */
+ pthread_mutex_t lock;
+};
+
+/* allocate a branching node of empty leaves */
+static SymbolTableNode *
+newSymbolTableNode(void)
+{
+ SymbolTableNode * tree = malloc(sizeof(SymbolTableNode) * 256);
+
+ for (int i = 0; i < 256; i++)
+ {
+ tree[i].status = is_free;
+ tree[i].u.symbol = -1;
+ }
+
+ return tree;
+}
+
+/* allocate a symbol table */
+SymbolTable
+newSymbolTable(void)
+{
+ SymbolTable st = malloc(sizeof(struct SymbolTable_st));
+
+ st->nsymbols = 0;
+ st->stored = 0;
+ st->next_avail = -1; /* means none */
+ st->root.status = is_free;
+ st->root.u.symbol = -1;
+ st->symbols_size = INITIAL_SYMBOL_SIZE;
+ st->symbols = malloc(sizeof(Symbol) * st->symbols_size);
+ if (pthread_mutex_init(&st->lock, NULL) != 0)
+ abort();
+
+ return st;
+}
+
+/* recursively free a symbol table tree */
+static void
+freeSymbolTableNode(SymbolTableNode * tree)
+{
+ if (tree->status == is_tree)
+ {
+ for (int i = 0; i < 256; i++)
+ freeSymbolTableNode(& tree->u.tree[i]);
+ free(tree->u.tree);
+ }
+}
+
+/* free symbol table st */
+void
+freeSymbolTable(SymbolTable st)
+{
+ freeSymbolTableNode(& st->root);
+ free(st->symbols);
+ pthread_mutex_destroy(&st->lock);
+ free(st);
+}
+
+/* how many symbols have been seen */
+int
+numberOfSymbols(SymbolTable st)
+{
+ return st->nsymbols;
+}
+
+/* dump tree to out, in byte order */
+static void
+dumpSymbolTableNode(FILE *out, SymbolTable st, SymbolTableNode *node)
+{
+ if (node == NULL)
+ fprintf(out, "(null)");
+ else
+ switch (node->status)
+ {
+ case is_tree:
+ for (int i = 0; i < 256; i++)
+ dumpSymbolTableNode(out, st, & node->u.tree[i]);
+ break;
+ case is_symb:
+ {
+ int n = node->u.symbol;
+ /* we could check n == number */
+ fprintf(out, "%s -> %d\n", st->symbols[n].name, st->symbols[n].number);
+ break;
+ }
+ case is_free:
+ if (node->u.symbol != -1)
+ fprintf(out, "free: %d\n", node->u.symbol);
+ break;
+ default:
+ /* cannot happen */
+ abort();
+ }
+}
+
+void
+dumpSymbolTable(FILE * out, const char *msg, SymbolTable st)
+{
+ fprintf(out, "SymbolTable %s dump: %d symbols (%d seen, %d avail)\n",
+ msg, st->stored, st->nsymbols, st->next_avail);
+ dumpSymbolTableNode(out, st, & st->root);
+ for (int i = 0; i < st->nsymbols; i++)
+ if (st->symbols[i].name != NULL)
+ fprintf(out, "[%d]: \"%s\"\n", i, st->symbols[i].name);
+ else
+ fprintf(out, "[%d]: *\n", i);
+}
+
+/* add new symbol to a node. NOT thread-safe. */
+static int
+addSymbol(SymbolTable st, SymbolTableNode *node, const char *name)
+{
+ int number;
+
+ if (st->next_avail != -1)
+ {
+ /* reuse freed number */
+ number = st->next_avail;
+ st->next_avail = st->symbols[number].number;
+ st->symbols[number].number = -1;
+ }
+ else
+ /* allocate a new number */
+ number = st->nsymbols++;
+
+ if (number >= st->symbols_size)
+ {
+ st->symbols_size *= 2;
+ st->symbols = realloc(st->symbols, sizeof(Symbol) * st->symbols_size);
+ }
+
+ st->symbols[number].name = pg_strdup(name);
+ /* not as silly as it looks: .number is -1 if symbol is removed */
+ st->symbols[number].number = number;
+
+ node->status = is_symb;
+ node->u.symbol = number;
+
+ st->stored++;
+ return number;
+}
+
+/* get existing id or create a new one for name in st */
+int
+getOrCreateSymbolId(SymbolTable st, const char *name)
+{
+ SymbolTableNode *node = & st->root;
+ Symbol *symb;
+ int i = 0;
+
+ /* get down to a leaf */
+ while (node->status == is_tree)
+ node = & node->u.tree[(unsigned char) name[i++]];
+
+ if (node->status == is_free)
+ {
+ int number;
+
+ /* empty leaf, let us use it */
+ pthread_mutex_lock(&st->lock);
+ number = addSymbol(st, node, name);
+ pthread_mutex_unlock(&st->lock);
+
+ return number;
+ }
+ /* else we have an existing symbol, which is name or a prefix of name */
+
+ symb = & st->symbols[node->u.symbol];
+
+ if ((i > 0 && strcmp(symb->name + i - 1, name + i - 1) == 0) ||
+ strcmp(symb->name, name) == 0)
+ /* already occupied by same name */
+ return symb->number;
+ else /* it contains a prefix of name */
+ {
+ int prev,
+ number;
+
+ /* should lock be acquire before? or redo the descent? */
+ pthread_mutex_lock(&st->lock);
+ prev = node->u.symbol;
+
+ /* expand tree from current node */
+ do
+ {
+ SymbolTableNode *prev_node;
+
+ node->status = is_tree;
+ node->u.tree = newSymbolTableNode();
+ prev_node = & node->u.tree[(unsigned char) st->symbols[prev].name[i]];
+ prev_node->status = is_symb;
+ prev_node->u.symbol = prev;
+ node = & node->u.tree[(unsigned char) name[i++]];
+ } while (node->status != is_free);
+
+ number = addSymbol(st, node, name);
+ pthread_mutex_unlock(&st->lock);
+
+ return number;
+ }
+}
+
+/* return symbol number that exists or -1 */
+int
+getSymbolId(SymbolTable st, const char * name)
+{
+ SymbolTableNode *node = & st->root;
+ int i = 0;
+ int n;
+
+ while (node->status == is_tree)
+ node = & node->u.tree[(unsigned char) name[i++]];
+
+ n = node->u.symbol;
+
+ if (node->status == is_symb &&
+ ((i>0 && strcmp(st->symbols[n].name + i - 1, name + i - 1) == 0) ||
+ strcmp(st->symbols[n].name, name) == 0))
+ return st->symbols[n].number; /* must be n */
+ else
+ return -1;
+}
+
+/* return symbol name if exists, or NULL */
+char *
+getSymbolName(SymbolTable st, int number)
+{
+ return 0 <= number && number < st->nsymbols ? st->symbols[number].name : NULL;
+}
+
+/* remove name from st, return its number or -1 if not found */
+int
+rmSymbolId(SymbolTable st, const char * name)
+{
+ SymbolTableNode *node = & st->root;
+ int i = 0,
+ num;
+
+ pthread_mutex_lock(&st->lock);
+
+ while (node->status == is_tree)
+ node = & node->u.tree[(unsigned char) name[i++]];
+
+ num = node->u.symbol;
+
+ if (node->status == is_symb && strcmp(st->symbols[num].name, name) == 0)
+ {
+ free(st->symbols[num].name);
+ st->symbols[num].name = NULL;
+ st->symbols[num].number = st->next_avail;
+ st->next_avail = num;
+ node->status = is_free;
+ node->u.symbol = -1;
+ st->stored--;
+ }
+ else
+ /* symbol is not there */
+ num = -1;
+
+ pthread_mutex_unlock(&st->lock);
+
+ return num;
+}
diff --git a/src/bin/pgbench/symbol_table_test.c b/src/bin/pgbench/symbol_table_test.c
new file mode 100644
index 0000000000..da3c52db9e
--- /dev/null
+++ b/src/bin/pgbench/symbol_table_test.c
@@ -0,0 +1,65 @@
+/* standalone compilation for testing
+ * cc -O -o symbol_table_test symbol_table_test.c
+ */
+
+#include <stdlib.h>
+#include <stdio.h>
+#include <string.h>
+
+#define pg_strdup strdup
+typedef enum { false, true } bool;
+struct SymbolTable_st;
+typedef struct SymbolTable_st *SymbolTable;
+SymbolTable newSymbolTable(void);
+void freeSymbolTable(SymbolTable st);
+void dumpSymbolTable(FILE *out, const char *msg, SymbolTable st);
+int numberOfSymbols(SymbolTable st);
+int getOrCreateSymbolId(SymbolTable st, const char *name);
+int getSymbolId(SymbolTable st, const char *name);
+char *getSymbolName(SymbolTable st, int number);
+int rmSymbolId(SymbolTable st, const char *name);
+
+#define STANDALONE
+#include "symbol_table.c"
+
+#define SYMBOLS 30
+
+int
+main(void)
+{
+ char *names[SYMBOLS] = {
+ "calvin", "hobbes", "calvin", "susie", "moe", "rosalyn",
+ "v", "va", "var", "var1", "var2", "var3",
+ "var11", "var1", "var11", "hobbes", "moe", "v", "",
+ "é", "été", "ét", "étage", "étirer", "étape",
+ "ä½ å¥½!", "ä½ å¥½", "ä½ ",
+ "µà i©çéèæijÅâåâ¬Ã§Ã¾Ã½Ã»Â¶ÃøñæðÃÃù«»©®®Ã¬", "hello world"
+ };
+
+ SymbolTable st = newSymbolTable();
+
+ for (int i = 0; i < SYMBOLS; i++)
+ {
+ fprintf(stdout, "# %s (%ld)\n", names[i], strlen(names[i]));
+ int prev = getSymbolId(st, names[i]);
+ int add = getOrCreateSymbolId(st, names[i]);
+ int post = getSymbolId(st, names[i]);
+ int rm = rmSymbolId(st, "moe");
+ fprintf(stdout, "%d %d %d %d\n", prev, add, post, rm);
+ }
+
+ dumpSymbolTable(stdout, "first", st);
+
+ for (int i = SYMBOLS - 1; i >= 0; i--)
+ fprintf(stdout, "rm \"%s\": %d\n", names[i], rmSymbolId(st, names[i]));
+
+ dumpSymbolTable(stdout, "cleaned", st);
+
+ for (int i = SYMBOLS - 1; i >= 0; i--)
+ fprintf(stdout, "add \"%s\": %d\n", names[i], getOrCreateSymbolId(st, names[i]));
+
+ dumpSymbolTable(stdout, "end", st);
+
+ freeSymbolTable(st);
+ return 0;
+}
diff --git a/src/bin/pgbench/t/001_pgbench_with_server.pl b/src/bin/pgbench/t/001_pgbench_with_server.pl
index b82d3f65c4..493f9ec883 100644
--- a/src/bin/pgbench/t/001_pgbench_with_server.pl
+++ b/src/bin/pgbench/t/001_pgbench_with_server.pl
@@ -622,14 +622,14 @@ SELECT LEAST(} . join(', ', (':i') x 256) . q{)}
[qr{unexpected function name}], q{\set i noSuchFunction()}
],
[
- 'set invalid variable name', 2,
+ 'set invalid variable name', 1,
[qr{invalid variable name}], q{\set . 1}
],
[ 'set division by zero', 2, [qr{division by zero}], q{\set i 1/0} ],
[
'set undefined variable',
2,
- [qr{undefined variable "nosuchvariable"}],
+ [qr{no value for variable "nosuchvariable"}],
q{\set i :nosuchvariable}
],
[ 'set unexpected char', 1, [qr{unexpected character .;.}], q{\set i ;} ],
set_x_1.sql
Description: application/sql
sets.sql
Description: application/sql
gset_aid.sql
Description: application/sql
