Re: partition routing layering in nodeModifyTable.c

[Amit Langote]

On Wed, Aug 7, 2019 at 12:00 PM Etsuro Fujita <etsuro.fuj...@gmail.com> wrote:
> IIUC, I think we reached a consensus at least on the 0001 patch.
> Andres, would you mind if I commit that patch?

I just noticed obsolete references to es_result_relation_info that
0002 failed to remove.  One of them is in fdwhandler.sgml:

<programlisting>
TupleTableSlot *
IterateDirectModify(ForeignScanState *node);
</programlisting>

    ... The data that was actually inserted, updated
     or deleted must be stored in the
     
<literal>es_result_relation_info-&gt;ri_projectReturning-&gt;pi_exprContext-&gt;ecxt_scantuple</literal>
     of the node's <structname>EState</structname>.

We will need to rewrite this without mentioning
es_result_relation_info.  How about as follows:

-     
<literal>es_result_relation_info-&gt;ri_projectReturning-&gt;pi_exprContext-&gt;ecxt_scantuple</literal>
-     of the node's <structname>EState</structname>.
+     
<literal>ri_projectReturning-&gt;pi_exprContext-&gt;ecxt_scantuple</literal>
+     of the result relation's<structname>ResultRelInfo</structname> that has
+     been made available via node.

I've updated 0001 with the above change.

Also, I updated 0002 to remove other references.

Thanks,
Amit

v6-0001-Revise-BeginDirectModify-API-to-pass-ResultRelInf.patch
Description: Binary data

v6-0002-Remove-es_result_relation_info.patch
Description: Binary data

v6-0004-Refactor-transition-tuple-capture-code-a-bit.patch
Description: Binary data

v6-0003-Rearrange-partition-update-row-movement-code-a-bi.patch
Description: Binary data