Andres Freund <and...@anarazel.de> writes:
> On 2019-08-03 19:41:55 +0900, Etsuro Fujita wrote:
>> What API does that function break?
> You need to call it, whereas previously you did not need to call it. The
> effort to change an FDW to get one more parameter, or to call that
> function is about the same.
If those are the choices, adding a parameter is clearly the preferable
solution, because it makes the API breakage obvious at compile.
Adding a function would make sense, perhaps, if only a minority of FDWs
need to do so. It'd still be risky if the need to do so could be missed
in light testing.
regards, tom lane
