On 2019-Jul-28, Tom Lane wrote: > Andres Freund <and...@anarazel.de> writes: > > a few prototypes look odd. It appears to be cases where previously the > > odd indentation was put to some use, by indenting parameters less: > > ... > > but now that looks odd: > > extern void DefineCustomBoolVariable( > > const char *name, > > const char *short_desc, > > > Unless somebody protests I'm going to remove the now pretty useless > > looking newline in the cases I can find. > > +1. I think Alvaro was muttering something about doing this, > but you beat him to it.
No, this is a different issue ... I was talking about function *calls* ending in parens, and it changed because of the previous round of pgindent changes, not the last one. The number of affected places was a lot larger than the patch Andres posted. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
