On Wed, Jul 24, 2019 at 11:04 PM vignesh C <vignes...@gmail.com> wrote: > > Hi, > > I have done some review of undolog patch series > and here are my comments: > 0003-Add-undo-log-manager.patch > > 1) As undo log is being created in tablespace, > if the tablespace is dropped later, will it have any impact? >
Yes, it drops the undo logs present in tablespace being dropped. See DropUndoLogsInTablespace() in the same patch. > > 4) Should we add a readme file for undolog as it does a fair amount of work > and is core part of the undo system? > The Readme is already present in the patch series posted by Thomas. See 0019-Add-developer-documentation-for-the-undo-log-storage.patch in email [1]. [1] - https://www.postgresql.org/message-id/CA%2BhUKGKni7EEU4FT71vZCCwPeaGb2PQOeKOFjQJavKnD577UMQ%40mail.gmail.com -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
