On Tue, Jun 18, 2019 at 09:59:08AM +0900, Michael Paquier wrote: > On Mon, Jun 17, 2019 at 10:50:39AM -0400, Alvaro Herrera wrote: > > I think this should be note() rather than print(), or maybe diag(). (I > > see that we have a couple of other cases which use print() in the tap > > tests, which I think should be note() as well.) > > OK. Let's change it for this patch.
PostgresNode uses "print" the same way. The patch does close the intended race conditions, and its implementation choices look fine to me.