On Tue, Jul 16, 2019 at 10:15 AM David Rowley <david.row...@2ndquadrant.com> wrote: > On Tue, 16 Jul 2019 at 03:13, Robert Haas <robertmh...@gmail.com> wrote: > > I vote for changing it to NOTICE instead of DEBUG1. > > Well, there are certainly other DDL commands that spit out NOTICES. > > postgres=# create table z (a int); > CREATE TABLE > postgres=# create table x (a int) inherits(z); > NOTICE: merging column "a" with inherited definition > CREATE TABLE > > However, we did get rid of a few of those a while back. In 9.2 we used to > have: > > postgres=# create table a (a int primary key); > NOTICE: CREATE TABLE / PRIMARY KEY will create implicit index > "a_pkey" for table "a" > > I'm pretty keen for consistency. Having ATTACH PARTITION spit out an > INFO and merge attributes a NOTICE, and SET NOT NULL just a DEBUG1 is > pretty far from consistent. I wouldn't object to making them all > NOTICE. I've only seen complaints about the INFO one.
Fwiw, I'm leaning toward NOTICE for all. It's helpful for users to know a certain action was taken. Thanks, Amit
