On Fri, May 10, 2019 at 8:54 AM Shawn Debnath <s...@amazon.com> wrote: > On Wed, May 08, 2019 at 06:31:04PM +1200, Thomas Munro wrote: > Looks good to me. Minor nit: update the comment for XLogRecGetBlockTag:
Fixed. Also fixed broken upgrade scripts for pg_buffercache extension, as pointed out by Robert[1] on the main thread where undo stuff is being discussed. Attempts to keep subtopics separated have so far failed, so the thread ostensibly about orphaned file cleanup is now about undo work allocation, but I figured it'd be useful to highlight this patch separately as it'll be the first to go in, and it's needed by your work Shawn. So I hope we're still on the same page with this refactoring patch. One thing I'm not sure about is the TODO message in parsexlog.c's extractPageInfo() function. [1] https://www.postgresql.org/message-id/CA%2BTgmob4htT-9Tq7eHG3wS%3DdpKFbQZOyqgSr1iWmV_65Duz6Pw%40mail.gmail.com -- Thomas Munro https://enterprisedb.com
0002-Move-tablespace-dir-creation-from-smgr.c-to-md.c.patch
Description: Binary data
0001-Add-SmgrId-to-smgropen-and-BufferTag.patch
Description: Binary data
